From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932727Ab0JLPvB (ORCPT ); Tue, 12 Oct 2010 11:51:01 -0400 Received: from cpoproxy3-pub.bluehost.com ([67.222.54.6]:52727 "HELO cpoproxy3-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1757609Ab0JLPuv (ORCPT ); Tue, 12 Oct 2010 11:50:51 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=virtuousgeek.org; h=Received:Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding:X-Identified-User; b=hWcL94yM/+yNMHfYEKn2EiYJr8qQfEU4U4JVRcU3KPOy7k42N3tNRb4LnLc3A5lS9cv1e8bHb6fxi3rxkc+Y7luXapTbCZUmL+VxSyRD/UkwJVgxvfyXtmsKta8gmxkq; Date: Tue, 12 Oct 2010 08:54:22 -0700 From: Jesse Barnes To: Konrad Rzeszutek Wilk Cc: linux-kernel@vger.kernel.org, Jan Beulich , xen-devel@lists.xensource.com, Jeremy Fitzhardinge , Konrad Rzeszutek Wilk , Stefano Stabellini , Jeremy Fitzhardinge , x86@kernel.org Subject: Re: [PATCH 13/23] x86/PCI: make sure _PAGE_IOMAP it set on pci mappings Message-ID: <20101012085422.04b4e1c9@jbarnes-desktop> In-Reply-To: <1286898271-32018-14-git-send-email-konrad.wilk@oracle.com> References: <1286898271-32018-1-git-send-email-konrad.wilk@oracle.com> <1286898271-32018-14-git-send-email-konrad.wilk@oracle.com> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Identified-User: {10642:box514.bluehost.com:virtuous:virtuousgeek.org} {sentby:smtp auth 67.174.193.198 authed with jbarnes@virtuousgeek.org} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Oct 2010 11:44:21 -0400 Konrad Rzeszutek Wilk wrote: > From: Jeremy Fitzhardinge > > When mapping pci space via /sys or /proc, make sure we're really > doing a hardware mapping by setting _PAGE_IOMAP. > > [ Impact: bugfix; make PCI mappings map the right pages ] > > Signed-off-by: Jeremy Fitzhardinge > Reviewed-by: Konrad Rzeszutek Wilk > Reviewed-by: "H. Peter Anvin" > Reviewed-by: Matthew Wilcox > Cc: x86@kernel.org > Cc: Jesse Barnes > --- > arch/x86/pci/i386.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/arch/x86/pci/i386.c b/arch/x86/pci/i386.c > index 5525309..8379c2c 100644 > --- a/arch/x86/pci/i386.c > +++ b/arch/x86/pci/i386.c > @@ -311,6 +311,8 @@ int pci_mmap_page_range(struct pci_dev *dev, struct vm_area_struct *vma, > */ > prot |= _PAGE_CACHE_UC_MINUS; > > + prot |= _PAGE_IOMAP; /* creating a mapping for IO */ > + > vma->vm_page_prot = __pgprot(prot); > > if (io_remap_pfn_range(vma, vma->vm_start, vma->vm_pgoff, Looks fine. Acked-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center