From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758055Ab0JLSaJ (ORCPT ); Tue, 12 Oct 2010 14:30:09 -0400 Received: from charlotte.tuxdriver.com ([70.61.120.58]:40940 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752922Ab0JLSaH (ORCPT ); Tue, 12 Oct 2010 14:30:07 -0400 Date: Tue, 12 Oct 2010 14:18:04 -0400 From: "John W. Linville" To: Linus Torvalds Cc: linux-wireless@vger.kernel.org, Stephen Rothwell , Ben Greear , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ath5k: fix build break from "ath5k: Print out opmode in debugfs" Message-ID: <20101012181804.GC2403@tuxdriver.com> References: <20101012163519.a88f2040.sfr@canb.auug.org.au> <1286895206-3030-1-git-send-email-linville@tuxdriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 12, 2010 at 11:13:31AM -0700, Linus Torvalds wrote: > On Tue, Oct 12, 2010 at 7:53 AM, John W. Linville > wrote: > > > > Please don't make me commit such an ugly patch... > >  Why don't you just create a dummy inline ath_opmode_to_string() that > returns NULL in the non-debug case? The compiler will make the > conditionals all go away, and it will end up being "UNKNOWN" which is > just what you want. No? Shhh! Your messing-up my manipulative mind games! :-) John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.