From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751530Ab0JMFEz (ORCPT ); Wed, 13 Oct 2010 01:04:55 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:40063 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751133Ab0JMFEy (ORCPT ); Wed, 13 Oct 2010 01:04:54 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Date: Wed, 13 Oct 2010 13:59:03 +0900 From: KAMEZAWA Hiroyuki To: "linux-mm@kvack.org" Cc: "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" , stable@kernel.org Subject: [BUGFIX][PATCH] fix return value of scan_lru_pages in memory unplug Message-Id: <20101013135903.c505ff8b.kamezawa.hiroyu@jp.fujitsu.com> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 3.0.3 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org CC'ed to stable tree...maybe all kernel has this bug. But this may not very critical because we've got no report until now. == From: KAMEZAWA Hiroyuki scan_lru_pages returns pfn. So, it's type should be "unsigned long" not "int". Note: I guess this has been work until now because memory hotplug tester's machine has not very big memory.... physical address < 32bit << PAGE_SHIFT. Reported-by: KOSAKI Motohiro Signed-off-by: KAMEZAWA Hiroyuki --- mm/memory_hotplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: mmotm-1008/mm/memory_hotplug.c =================================================================== --- mmotm-1008.orig/mm/memory_hotplug.c +++ mmotm-1008/mm/memory_hotplug.c @@ -646,7 +646,7 @@ static int test_pages_in_a_zone(unsigned * Scanning pfn is much easier than scanning lru list. * Scan pfn from start to end and Find LRU page. */ -int scan_lru_pages(unsigned long start, unsigned long end) +unsigned long scan_lru_pages(unsigned long start, unsigned long end) { unsigned long pfn; struct page *page;