From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Joe Perches <joe@perches.com>
Cc: Peter Hsiang <Peter.Hsiang@maxim-ic.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Peter Ujfalusi <peter.ujfalusi@nokia.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jesse Marroquin <Jesse.Marroquin@maxim-ic.com>
Subject: Re: [RFC PATCH] sound/soc/codecs/wm8962.c: Use register index, save 100kb text
Date: Wed, 13 Oct 2010 20:40:17 +0100 [thread overview]
Message-ID: <20101013194017.GB17574@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1286997031.1117.405.camel@Joe-Laptop>
On Wed, Oct 13, 2010 at 12:10:31PM -0700, Joe Perches wrote:
> I don't know if the binary chop is too cpu
> intensive or if too much data access would be
> a problem.
It's on my list to do something about this but if we're going to do
anything it should be in generic code - this is an issue which affects
a growing number of devices and there's enough code to mean that it
should be librified. This should ideally also involve compressing the
cache itself since that has a similar effect again.
I'm not a fan of doing device specific stuff here since it will make it
harder to transition those devices to use generic code, causing hassle
trying to maintain the subsystem. The size impact of doing something
simple is a bit annoying but not usually a pressing issue on devices
that would want a CODEC with a noticably large register map.
By the way, please try to provide prefixes for your patches which are
consistent with those normally used for the code you are modifying
rather than making up your own.
next prev parent reply other threads:[~2010-10-13 19:40 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 2:34 [PATCH] ASoC: Add max98088 CODEC driver Peter Hsiang
2010-09-29 3:37 ` Mark Brown
2010-09-29 21:42 ` Peter Hsiang
2010-09-29 22:18 ` Mark Brown
2010-09-30 0:52 ` Peter Hsiang
2010-09-30 0:58 ` Mark Brown
2010-09-30 1:20 ` Peter Hsiang
2010-10-13 1:20 ` Peter Hsiang
2010-10-13 1:47 ` Joe Perches
2010-10-13 8:24 ` Mark Brown
2010-10-13 12:10 ` [PATCH] sound/soc: rename vol to volatile_register as appropriate Joe Perches
2010-10-13 12:33 ` Mark Brown
2010-10-13 12:55 ` Joe Perches
2010-10-13 15:11 ` Mark Brown
2010-10-13 15:27 ` Joe Perches
2010-10-13 15:29 ` Mark Brown
2010-10-13 15:35 ` Joe Perches
2010-10-13 19:10 ` [RFC PATCH] sound/soc/codecs/wm8962.c: Use register index, save 100kb text Joe Perches
2010-10-13 19:40 ` Mark Brown [this message]
2010-10-13 20:06 ` Joe Perches
2010-10-13 20:29 ` Mark Brown
2010-10-13 15:19 ` [PATCH] sound/soc/codecs/wm8994.c: Remove unused vol Joe Perches
2010-10-15 10:08 ` Liam Girdwood
2010-10-15 10:39 ` Mark Brown
2010-10-13 10:32 ` [PATCH] ASoC: Add max98088 CODEC driver Mark Brown
2010-10-14 3:18 ` Peter Hsiang
2010-10-14 3:30 ` Peter Hsiang
2010-10-15 10:04 ` Liam Girdwood
2010-10-15 10:55 ` Mark Brown
2010-10-15 17:23 ` Peter Hsiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101013194017.GB17574@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=Jesse.Marroquin@maxim-ic.com \
--cc=Peter.Hsiang@maxim-ic.com \
--cc=alsa-devel@alsa-project.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@nokia.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®