From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754676Ab0JNGq0 (ORCPT ); Thu, 14 Oct 2010 02:46:26 -0400 Received: from smtp.nokia.com ([192.100.122.233]:48352 "EHLO mgw-mx06.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754048Ab0JNGqZ (ORCPT ); Thu, 14 Oct 2010 02:46:25 -0400 Date: Thu, 14 Oct 2010 09:45:25 +0300 (EEST) Message-Id: <20101014.094525.71092814.Hiroshi.DOYU@nokia.com> To: x0095840@ti.com Cc: felipe.contreras@nokia.com, tony@atomide.com, linux-kernel@vger.kernel.org, andy.shevchenko@gmail.com, linux-omap@vger.kernel.org Subject: Re: [PATCH 3/4] iovmm: replace __iounmap with omap_iounmap From: Hiroshi DOYU In-Reply-To: <1287023257-30951-4-git-send-email-x0095840@ti.com> References: <1287023257-30951-2-git-send-email-x0095840@ti.com> <1287023257-30951-3-git-send-email-x0095840@ti.com> <1287023257-30951-4-git-send-email-x0095840@ti.com> X-Mailer: Mew version 7.0.50 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 14 Oct 2010 06:45:32.0018 (UTC) FILETIME=[6595CD20:01CB6B6B] X-Nokia-AV: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Fernando, From: ext Fernando Guzman Lugo Subject: [PATCH 3/4] iovmm: replace __iounmap with omap_iounmap Date: Thu, 14 Oct 2010 04:27:36 +0200 > Omap platform is omap_iounmap function. > > Signed-off-by: Fernando Guzman Lugo > --- > arch/arm/plat-omap/iovmm.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c > index 93a34d9..5489ca9 100644 > --- a/arch/arm/plat-omap/iovmm.c > +++ b/arch/arm/plat-omap/iovmm.c > @@ -821,7 +821,7 @@ void iommu_kunmap(struct iommu *obj, u32 da) > struct sg_table *sgt; > typedef void (*func_t)(const void *); > > - sgt = unmap_vm_area(obj, da, (func_t)__iounmap, + sgt = unmap_vm_area(obj, da, (func_t)iounmap, Woundn't the above be enough? Eventually this "iounmap()" calls "__arch_iounmap()" -> "omap_iounmap()". I don't see any special reason to call "omap_iounmap()" here for now. > + sgt = unmap_vm_area(obj, da, (func_t)omap_iounmap, > IOVMF_LINEAR | IOVMF_MMIO); > if (!sgt) > dev_dbg(obj->dev, "%s: No sgt\n", __func__); > -- > 1.6.3.3 >