From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755222Ab0JNJrn (ORCPT ); Thu, 14 Oct 2010 05:47:43 -0400 Received: from smtp.nokia.com ([147.243.1.47]:38233 "EHLO mgw-sa01.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754828Ab0JNJrm (ORCPT ); Thu, 14 Oct 2010 05:47:42 -0400 Date: Thu, 14 Oct 2010 12:47:10 +0300 (EEST) Message-Id: <20101014.124710.71089824.Hiroshi.DOYU@nokia.com> To: fernando.lugo@ti.com Cc: felipe.contreras@nokia.com, tony@atomide.com, linux-kernel@vger.kernel.org, andy.shevchenko@gmail.com, linux-omap@vger.kernel.org Subject: Re: [PATCH 3/4] iovmm: replace __iounmap with omap_iounmap From: Hiroshi DOYU In-Reply-To: <496565EC904933469F292DDA3F1663E602F3E074FB@dlee06.ent.ti.com> References: <1287023257-30951-4-git-send-email-x0095840@ti.com> <20101014.094525.71092814.Hiroshi.DOYU@nokia.com> <496565EC904933469F292DDA3F1663E602F3E074FB@dlee06.ent.ti.com> X-Mailer: Mew version 7.0.50 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Nokia-AV: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "ext Guzman Lugo, Fernando" Subject: RE: [PATCH 3/4] iovmm: replace __iounmap with omap_iounmap Date: Thu, 14 Oct 2010 10:18:30 +0200 > >> ________________________________________ >> From: Hiroshi DOYU [Hiroshi.DOYU@nokia.com] >> Sent: Thursday, October 14, 2010 1:45 AM >> To: Guzman Lugo, Fernando >> Cc: felipe.contreras@nokia.com; tony@atomide.com; >> linux-kernel@vger.kernel.org; andy.shevchenko@gmail.com; linux-omap@vger.kernel.org >> Subject: Re: [PATCH 3/4] iovmm: replace __iounmap with omap_iounmap >> >> Hi Fernando, >> >> From: ext Fernando Guzman Lugo >> Subject: [PATCH 3/4] iovmm: replace __iounmap with omap_iounmap >> Date: Thu, 14 Oct 2010 04:27:36 +0200 >> >> > Omap platform is omap_iounmap function. >> > >> > Signed-off-by: Fernando Guzman Lugo >> > --- >> > arch/arm/plat-omap/iovmm.c | 2 +- >> > 1 files changed, 1 insertions(+), 1 deletions(-) >> > >> > diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c >> > index 93a34d9..5489ca9 100644 >> > --- a/arch/arm/plat-omap/iovmm.c >> > +++ b/arch/arm/plat-omap/iovmm.c >> > @@ -821,7 +821,7 @@ void iommu_kunmap(struct iommu *obj, u32 da) >> > struct sg_table *sgt; >> > typedef void (*func_t)(const void *); >> > >> > - sgt = unmap_vm_area(obj, da, (func_t)__iounmap, >> >> + sgt = unmap_vm_area(obj, da, (func_t)iounmap, >> >> Woundn't the above be enough? >> >> Eventually this "iounmap()" calls "__arch_iounmap()" -> >> "omap_iounmap()". I don't see any special reason to call >> "omap_iounmap()" here for now. > > iounmap and __arch_iounmap are macros they cannot not > be used there. If so, it gives a "undeclared" compile error. Ok. I'll add this explanation as a note on this commit.