From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jason Baron <jbaron@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 3/9] jump label: Fix module __init section race
Date: Sat, 16 Oct 2010 08:23:04 +0200 [thread overview]
Message-ID: <20101016062304.GA10748@elte.hu> (raw)
In-Reply-To: <1287194942.16971.39.camel@gandalf.stny.rr.com>
* Steven Rostedt <rostedt@goodmis.org> wrote:
> On Fri, 2010-10-15 at 16:09 -0400, Steven Rostedt wrote:
>
> > --- a/kernel/jump_label.c
> > +++ b/kernel/jump_label.c
> > @@ -168,7 +168,8 @@ void jump_label_update(unsigned long key, enum jump_label_type type)
> > count = e_module->nr_entries;
> > iter = e_module->table;
> > while (count--) {
> > - if (kernel_text_address(iter->code))
> > + if (iter->key &&
> > + kernel_text_address(iter->code))
>
> Peter, I know you hated this, but the alternative is either:
>
> if (iter->key &&
> kernel_text_address(iter->code))
>
> or break 80 chars. All three seem bad (although I don't mind breaking
> 80 chars for this). But I'll leave it for now.
No, the proper alternative is to move the body of the iteration into a
jump_label_update_entry() inline function ...
Nobody is forcing you to start yet another iteration 4 indentations
deep. We have functions for a reason.
Thanks,
Ingo
next prev parent reply other threads:[~2010-10-16 6:23 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 20:09 [PATCH 0/9] [GIT PULL] jump label: various updates Steven Rostedt
2010-10-15 20:09 ` [PATCH 1/9] jump label/x86: Move arch_init_ideal_nop5 later Steven Rostedt
2010-10-15 20:09 ` [PATCH 2/9] tracing/x86: No need to disable interrupts when calling arch_init_ideal_nop5 Steven Rostedt
2010-10-15 20:09 ` [PATCH 3/9] jump label: Fix module __init section race Steven Rostedt
2010-10-16 2:09 ` Steven Rostedt
2010-10-16 6:23 ` Ingo Molnar [this message]
2010-10-16 16:23 ` Steven Rostedt
2010-10-18 14:14 ` Jason Baron
2010-10-15 20:09 ` [PATCH 4/9] jump label: Fix deadlock b/w jump_label_mutex vs. text_mutex Steven Rostedt
2010-10-15 20:55 ` Peter Zijlstra
2010-10-16 2:16 ` Steven Rostedt
2010-10-16 2:25 ` Steven Rostedt
2010-10-16 4:21 ` Steven Rostedt
2010-10-15 20:09 ` [PATCH 5/9] jump label: Add register_jump_label_key/unregister_jump_label_key Steven Rostedt
2010-10-15 20:58 ` Peter Zijlstra
2010-10-16 2:11 ` Steven Rostedt
2010-10-15 21:03 ` Peter Zijlstra
2010-10-15 21:09 ` Steven Rostedt
2010-10-15 21:13 ` Peter Zijlstra
2010-10-18 12:05 ` Peter Zijlstra
2010-10-18 14:03 ` Jason Baron
2010-10-18 14:07 ` Peter Zijlstra
2010-10-15 20:09 ` [PATCH 6/9] jump label: Move jump table to r/w section Steven Rostedt
2010-10-15 20:09 ` [PATCH 7/9] jump label: Add docs Steven Rostedt
2010-10-15 20:09 ` [PATCH 8/9] jump label: Make arch_jump_label_text_poke_early() optional Steven Rostedt
2010-10-15 21:06 ` Peter Zijlstra
2010-10-15 21:08 ` Steven Rostedt
2010-10-15 21:22 ` David Daney
2010-10-15 21:35 ` Steven Rostedt
2010-10-15 21:38 ` David Daney
2010-10-16 1:08 ` Steven Rostedt
2010-10-30 10:40 ` [tip:perf/urgent] " tip-bot for Steven Rostedt
2010-10-15 20:09 ` [PATCH 9/9] jump label: Add MIPS support Steven Rostedt
2010-10-15 20:17 ` [PATCH 0/9] [GIT PULL] jump label: various updates Steven Rostedt
2010-10-16 1:10 ` Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2010-10-04 18:56 [PATCH v2 0/2] jump label: Add MIPS architecture support David Daney
2010-10-04 18:56 ` [PATCH v2 1/2] jump label: Make arch_jump_label_text_poke_early() optional David Daney
2010-10-04 18:56 ` [PATCH v2 2/2] jump label: Add MIPS support David Daney
2010-10-06 23:00 ` Ralf Baechle
2010-10-07 1:26 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101016062304.GA10748@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome