Re: [PATCH] mfd/tc6393xb: don't use devinit data from non-init function

["Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>]

Hello,

On Tue, Mar 02, 2010 at 05:22:33PM +0100, Uwe Kleine-König wrote:
> tc6393xb_mmc_resources (which was marked __devinitdata) is used in
> tc6393xb_mmc_enable() and tc6393xb_mmc_resume() which both are functions
> living in .text.  This is not save with CONFIG_HOTPLUG=n.
> 
> This was introduced in
> 
> 	64e8867 (mfd: tmio_mmc hardware abstraction for CNF area)
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Ian Molton <ian@mnementh.co.uk>
> Cc: Magnus Damm <damm@opensource.se>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
ping

Uwe
> ---
>  drivers/mfd/tc6393xb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mfd/tc6393xb.c b/drivers/mfd/tc6393xb.c
> index 4bc5a08..b057d8d 100644
> --- a/drivers/mfd/tc6393xb.c
> +++ b/drivers/mfd/tc6393xb.c
> @@ -154,7 +154,7 @@ static struct resource __devinitdata tc6393xb_nand_resources[] = {
>  	},
>  };
>  
> -static struct resource __devinitdata tc6393xb_mmc_resources[] = {
> +static struct resource tc6393xb_mmc_resources[] = {
>  	{
>  		.start	= 0x800,
>  		.end	= 0x9ff,
> -- 
> 1.7.0
> 
> 

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |