From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933595Ab0JSI37 (ORCPT ); Tue, 19 Oct 2010 04:29:59 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:40552 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932393Ab0JSI36 (ORCPT ); Tue, 19 Oct 2010 04:29:58 -0400 Date: Tue, 19 Oct 2010 11:29:41 +0300 From: Felipe Balbi To: Felipe Contreras Cc: "Balbi, Felipe" , "linux-usb@vger.kernel.org" , linux-main , Greg KH Subject: Re: [PATCH 2/3] usb: trivial Kconfig cleanups Message-ID: <20101019082941.GA31170@legolas.emea.dhcp.ti.com> Reply-To: balbi@ti.com References: <1287475466-8927-1-git-send-email-felipe.contreras@gmail.com> <1287475466-8927-3-git-send-email-felipe.contreras@gmail.com> <20101019081509.GH12470@legolas.emea.dhcp.ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 19, 2010 at 03:25:27AM -0500, Felipe Contreras wrote: >On Tue, Oct 19, 2010 at 11:15 AM, Felipe Balbi wrote: >> On Tue, Oct 19, 2010 at 03:04:25AM -0500, Felipe Contreras wrote: >>> >>> @@ -125,14 +125,6 @@ config USB_MUSB_OTG >>> >>> endchoice >>> >>> -# enable peripheral support (including with OTG) >>> -config USB_GADGET_MUSB_HDRC >>> -       bool >>> -       depends on USB_MUSB_HDRC && (USB_MUSB_PERIPHERAL || USB_MUSB_OTG) >>> -#      default y >>> -#      select USB_GADGET_DUALSPEED >>> -#      select USB_GADGET_SELECTED >>> - >> >> $ git grep -e CONFIG_USB_GADGET_MUSB_HDRC drivers/usb/ >> drivers/usb/gadget/gadget_chips.h:#ifdef CONFIG_USB_GADGET_MUSB_HDRC >> drivers/usb/musb/Makefile:ifeq ($(CONFIG_USB_GADGET_MUSB_HDRC),y) >> drivers/usb/musb/am35x.c:#ifdef CONFIG_USB_GADGET_MUSB_HDRC >> drivers/usb/musb/da8xx.c:#ifdef CONFIG_USB_GADGET_MUSB_HDRC >> drivers/usb/musb/musb_core.c:#ifdef CONFIG_USB_GADGET_MUSB_HDRC >> drivers/usb/musb/musb_core.c:#ifdef CONFIG_USB_GADGET_MUSB_HDRC >> drivers/usb/musb/musb_core.c:#ifdef CONFIG_USB_GADGET_MUSB_HDRC >> drivers/usb/musb/musb_core.c:#ifdef CONFIG_USB_GADGET_MUSB_HDRC >> drivers/usb/musb/musb_core.c:#endif /* CONFIG_USB_GADGET_MUSB_HDRC */ >> drivers/usb/musb/musb_core.c:#ifdef CONFIG_USB_GADGET_MUSB_HDRC >> drivers/usb/musb/musb_core.c:#ifdef CONFIG_USB_GADGET_MUSB_HDRC >> drivers/usb/musb/musb_core.c:#ifdef CONFIG_USB_GADGET_MUSB_HDRC >> drivers/usb/musb/musb_core.c:#elif defined(CONFIG_USB_GADGET_MUSB_HDRC) >> drivers/usb/musb/musb_core.h:#ifndef CONFIG_USB_GADGET_MUSB_HDRC >> drivers/usb/musb/musb_core.h:#error bogus Kconfig output ... select >> CONFIG_USB_GADGET_MUSB_HDRC >> drivers/usb/musb/musb_core.h:#ifdef CONFIG_USB_GADGET_MUSB_HDRC >> drivers/usb/musb/musb_core.h:#ifdef CONFIG_USB_GADGET_MUSB_HDRC >> drivers/usb/musb/musb_core.h:#ifdef CONFIG_USB_GADGET_MUSB_HDRC >> drivers/usb/musb/musb_core.h:#ifdef CONFIG_USB_GADGET_MUSB_HDRC >> drivers/usb/musb/musb_core.h:#ifdef CONFIG_USB_GADGET_MUSB_HDRC >> drivers/usb/musb/musb_core.h:#ifdef CONFIG_USB_GADGET_MUSB_HDRC >> drivers/usb/musb/tusb6010.c:#ifdef CONFIG_USB_GADGET_MUSB_HDRC >> drivers/usb/musb/tusb6010.c:#ifdef CONFIG_USB_GADGET_MUSB_HDRC >> drivers/usb/musb/tusb6010.c:#ifdef CONFIG_USB_GADGET_MUSB_HDRC > >So? > >% git grep USB_GADGET_MUSB_HDRC -- '*/Kconfig' >drivers/usb/gadget/Kconfig:config USB_GADGET_MUSB_HDRC >drivers/usb/musb/Kconfig:# use USB_GADGET_MUSB_HDRC not >USB_MUSB_PERIPHERAL to #ifdef peripheral >drivers/usb/musb/Kconfig: select USB_GADGET_MUSB_HDRC >drivers/usb/musb/Kconfig: select USB_GADGET_MUSB_HDRC >drivers/usb/musb/Kconfig:config USB_GADGET_MUSB_HDRC >drivers/usb/musb/Kconfig: select USB_OTG if USB_GADGET_MUSB_HDRC > >(it's defined twice) you're right, had missed that. This is ok too. -- balbi