mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Neil Horman <nhorman@tuxdriver.com>
To: David Miller <davem@davemloft.net>
Cc: luca@llucax.com.ar, paul.gortmaker@windriver.com,
	jon.maloy@ericsson.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	tipc-discussion@lists.sourceforge.net
Subject: Re: Linux 2.6.35/TIPC 2.0 ABI breaking changes
Date: Tue, 19 Oct 2010 07:04:52 -0400	[thread overview]
Message-ID: <20101019110452.GA14410@hmsreliant.think-freely.org> (raw)
In-Reply-To: <20101019.011649.71113115.davem@davemloft.net>

On Tue, Oct 19, 2010 at 01:16:49AM -0700, David Miller wrote:
> From: Leandro Lucarella <luca@llucax.com.ar>
> Date: Mon, 18 Oct 2010 23:16:57 -0300
> 
> > 
> > The problem is not between the tipc stacks in different hosts, is
> > between the tipc stack and the applications using it (well, maybe
> > there is a problem somewhere else too).
> > 
> > This was a deliberate API change, not a subtle bug...
> 
> Neil et al., if these packets live only between the kernel stack
> and the userspace API layer, we should not be byte-swapping this
> stuff and we need to fix this fast.
> 
Copy that Dave.  I think I see the problem.  The subscription code handles
messages both off the wire and from local user space.  The off the wire case
should work because the subscription code assumes that all the incomming data is
in network byte order, but user space is an exception to that rule as its in
local byte order.  I'll have a patch together for Leandro to test soon.
Neil

> Thanks.
> 

  reply	other threads:[~2010-10-19 11:05 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20100927163823.GD2834@integratech.com.ar>
     [not found] ` <29C1DC0826876849BDD9F1C67ABA2943090B67EC@ala-mail09.corp.ad.wrs.com>
     [not found]   ` <20100929153805.GG2834@integratech.com.ar>
     [not found]     ` <29C1DC0826876849BDD9F1C67ABA29430914AC18@ala-mail09.corp.ad.wrs.com>
     [not found]       ` <20101001150034.GS8781@llucax.com.ar>
     [not found]         ` <0434463FDA60A94FA978ACA44617682DEE843EDD79@EUSAACMS0702.eamcs.ericsson.se>
     [not found]           ` <20101001162346.GV8781@llucax.com.ar>
     [not found]             ` <4CA69F18.7000005@amln.net>
     [not found]               ` <0434463FDA60A94FA978ACA44617682DEE8446A03B@EUSAACMS0702.eamcs.ericsson.se>
2010-10-18 15:04                 ` Linux 2.6.35/TIPC 2.0 ABI breaking changes [was: TIPC 2.0 and TIPC_SUB_SERVICE] Leandro Lucarella
2010-10-18 18:46                   ` Leandro Lucarella
2010-10-18 20:42                     ` Paul Gortmaker
2010-10-18 22:17                       ` Linux 2.6.35/TIPC 2.0 ABI breaking changes David Miller
2010-10-18 23:11                         ` Paul Gortmaker
2010-10-18 23:38                           ` Leandro Lucarella
2010-10-18 23:45                           ` Neil Horman
2010-10-19  2:16                             ` Leandro Lucarella
2010-10-19  8:16                               ` David Miller
2010-10-19 11:04                                 ` Neil Horman [this message]
2010-10-19 11:06                                   ` David Miller
2010-10-19 13:19                                   ` Leandro Lucarella
2010-10-19 13:28                                     ` Neil Horman
2010-10-19 20:18                                     ` Neil Horman
2010-10-19 20:43                                       ` Leandro Lucarella
2010-10-19 22:03                                         ` Leandro Lucarella
2010-10-20 17:20                                       ` Leandro Lucarella
2010-10-20 17:57                                         ` Jon Maloy
2010-10-20 18:04                                           ` Neil Horman
2010-10-20 18:10                                             ` Jon Maloy
2010-10-20 18:28                                               ` Leandro Lucarella
2010-10-20 19:23                                                 ` Leandro Lucarella
2010-10-20 22:59                                                   ` Leandro Lucarella
2010-10-20 18:24                                           ` Leandro Lucarella
2010-10-20 18:37                                             ` Jon Maloy
2010-10-20 18:44                                               ` Leandro Lucarella
2010-10-20 17:57                                         ` Neil Horman
2010-10-18 23:58                         ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101019110452.GA14410@hmsreliant.think-freely.org \
    --to=nhorman@tuxdriver.com \
    --cc=davem@davemloft.net \
    --cc=jon.maloy@ericsson.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca@llucax.com.ar \
    --cc=netdev@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=tipc-discussion@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®