From: Andi Kleen <andi@firstfloor.org>
To: Shaohua Li <shaohua.li@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
Andi Kleen <andi@firstfloor.org>,
lkml <linux-kernel@vger.kernel.org>,
"Chen, Tim C" <tim.c.chen@intel.com>
Subject: Re: [patch]x86: spread tlb flush vector between nodes
Date: Tue, 19 Oct 2010 15:34:26 +0200 [thread overview]
Message-ID: <20101019133426.GB11654@basil.fritz.box> (raw)
In-Reply-To: <1287494931.1699.12.camel@shli-laptop>
>
> +static int tlb_vector_offset[NR_CPUS] __read_mostly;
Never use NR_CPUS. Always use per cpu data.
Otherwise you waste a lot of space on a CONFIG_MAX_SMP
kernel running on a smaller box.
-Andi
next prev parent reply other threads:[~2010-10-19 13:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 7:41 Shaohua Li
2010-10-13 8:16 ` Andi Kleen
2010-10-13 8:39 ` Shaohua Li
2010-10-13 11:19 ` Ingo Molnar
2010-10-19 5:39 ` Shaohua Li
2010-10-19 6:21 ` H. Peter Anvin
2010-10-19 8:44 ` Ingo Molnar
2010-10-19 8:55 ` Shaohua Li
2010-10-19 10:37 ` Ingo Molnar
2010-10-19 13:28 ` Shaohua Li
2010-10-19 13:34 ` Andi Kleen [this message]
2010-10-20 1:13 ` Shaohua Li
2010-10-20 2:39 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019133426.GB11654@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=shaohua.li@intel.com \
--cc=tim.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®