mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: rklein@nvidia.com
Cc: cboutatmailru@gmail.com, achew@nvidia.com, olof@lixom.net,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] power: bq24617: Adding initial charger support
Date: Wed, 20 Oct 2010 04:02:35 +0100	[thread overview]
Message-ID: <20101020030235.GA25392@sirena.org.uk> (raw)
In-Reply-To: <1287541031-17409-1-git-send-email-rklein@nvidia.com>

On Tue, Oct 19, 2010 at 07:17:11PM -0700, rklein@nvidia.com wrote:
> From: Rhyland Klein <rklein@nvidia.com>
> 
> Initial checkin adding basic support for the TI BQ24617 battery charger on the
> Nvidia Tegra architecture.

Why is this driver dependant on the CPU?  I can't see anything in the
code that makes it so.

> +	if (old_status != -1 &&
> +		old_status != new_status) {
> +		dev_dbg(&chip->pdev->dev,
> +			"%s: %i -> %i\n", __func__, old_status,
> +			new_status);
> +		kobject_uevent(&chip->power_supply.dev->kobj, KOBJ_CHANGE);

power_supply_changed().

> +static irqreturn_t bq24617_irq_switch(int irq, void *devid)
> +{
> +	struct bq24617_info *chip = devid;
> +
> +	schedule_work(&chip->ac_work);
> +
> +	return IRQ_HANDLED;
> +}

You're looking for a threaded IRQ handler here - use
request_threaded_irq() with no primary handler.

  reply	other threads:[~2010-10-20  3:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-20  2:17 rklein
2010-10-20  3:02 ` Mark Brown [this message]
2010-10-20 17:52   ` Rhyland Klein
2010-10-20 23:07     ` Rhyland Klein
2010-10-20 17:56   ` Rhyland Klein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101020030235.GA25392@sirena.org.uk \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=achew@nvidia.com \
    --cc=cboutatmailru@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=rklein@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®