From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752053Ab0JTJVh (ORCPT ); Wed, 20 Oct 2010 05:21:37 -0400 Received: from ganesha.gnumonks.org ([213.95.27.120]:57206 "EHLO ganesha.gnumonks.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751577Ab0JTJVg (ORCPT ); Wed, 20 Oct 2010 05:21:36 -0400 Date: Wed, 20 Oct 2010 11:11:51 +0200 From: Harald Welte To: Axel Lin Cc: linux-kernel , Samuel Ortiz Subject: Re: [PATCH] mfd: Fix resource reclaim in pcf50633_remove() Message-ID: <20101020091151.GD22198@prithivi.gnumonks.org> References: <1287565019.7849.2.camel@mola> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1287565019.7849.2.camel@mola> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Acked-by: Harald Welte On Wed, Oct 20, 2010 at 04:56:59PM +0800, Axel Lin wrote: > Calling sysfs_remove_group() to remove sysfs entries > and unregister bl_pdev in pcf50633_remove(). > > Signed-off-by: Axel Lin > --- > drivers/mfd/pcf50633-core.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c > index 6d4233f..501ce13 100644 > --- a/drivers/mfd/pcf50633-core.c > +++ b/drivers/mfd/pcf50633-core.c > @@ -339,12 +339,14 @@ static int __devexit pcf50633_remove(struct i2c_client *client) > struct pcf50633 *pcf = i2c_get_clientdata(client); > int i; > > + sysfs_remove_group(&client->dev.kobj, &pcf_attr_group); > pcf50633_irq_free(pcf); > > platform_device_unregister(pcf->input_pdev); > platform_device_unregister(pcf->rtc_pdev); > platform_device_unregister(pcf->mbc_pdev); > platform_device_unregister(pcf->adc_pdev); > + platform_device_unregister(pcf->bl_pdev); > > for (i = 0; i < PCF50633_NUM_REGULATORS; i++) > platform_device_unregister(pcf->regulator_pdev[i]); > -- > 1.7.2 > > > -- - Harald Welte http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)