From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>,
Stefani Seibold <stefani@seibold.net>
Subject: Re: kfifo must_check warning (+ patch)
Date: Wed, 20 Oct 2010 19:37:02 +0100 [thread overview]
Message-ID: <20101020193702.584f2c9a@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20101020094659.091113f5.randy.dunlap@oracle.com>
> Some versions of gcc mysteriously report:
> drivers/char/n_gsm.c:1580: warning: ignoring return value of '__kfifo_must_check_helper', declared with attribute warn_unused_result
>
> This warning can be eliminated by using a local variable for the
> returned result value, as suggested by Andrew Morton.
But that just hides the bug in the helper surely - the helper has type
errors so needs fixing - not this. If you apply this then the underlying
bug is just going to get forgotten
Alan
next prev parent reply other threads:[~2010-10-20 18:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 22:10 kfifo must_check warning Randy Dunlap
2010-10-20 5:12 ` Andrew Morton
2010-10-20 16:46 ` kfifo must_check warning (+ patch) Randy Dunlap
2010-10-20 17:51 ` miltonm
2010-10-20 18:37 ` Alan Cox [this message]
2010-10-20 18:56 ` Andrew Morton
2010-10-20 20:09 ` Stefani Seibold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101020193702.584f2c9a@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=stefani@seibold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®