From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757688Ab0JUTOp (ORCPT ); Thu, 21 Oct 2010 15:14:45 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:36519 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756760Ab0JUTOn (ORCPT ); Thu, 21 Oct 2010 15:14:43 -0400 Date: Thu, 21 Oct 2010 21:14:41 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Dinh.Nguyen@freescale.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk, s.hauer@pengutronix.de, valentin.longchamp@epfl.ch, daniel@caiaq.de, grant.likely@secretlab.ca, bryan.wu@canonical.com, amit.kucheria@canonical.com, xiao-lizhang@freescale.com Subject: Re: [PATCHv4 2/2] ARM: imx: Add wake functionality to GPIO Message-ID: <20101021191441.GY19834@pengutronix.de> References: <1287687324-6101-1-git-send-email-Dinh.Nguyen@freescale.com> <1287687324-6101-2-git-send-email-Dinh.Nguyen@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1287687324-6101-2-git-send-email-Dinh.Nguyen@freescale.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:215:17ff:fe12:23b0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 21, 2010 at 01:55:24PM -0500, Dinh.Nguyen@freescale.com wrote: > From: Dinh Nguyen > > Add function definition for irq_chip.set_wake to enable GPIO to > wake-up the system. > > This patch is based on Sascha Hauer's imx/linux-2.6 for-rmk tree. > > This patch has been tested on a MX51 Babbage system that had suspend > code implemented. The set_wake implementation is necessary for a > GPIO to wake up a system from suspend. > > Signed-off-by: Dinh Nguyen > --- > arch/arm/plat-mxc/gpio.c | 32 ++++++++++++++++++++++++++++++++ > 1 files changed, 32 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/plat-mxc/gpio.c b/arch/arm/plat-mxc/gpio.c > index 9d38da0..9c3e362 100644 > --- a/arch/arm/plat-mxc/gpio.c > +++ b/arch/arm/plat-mxc/gpio.c > @@ -20,6 +20,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -201,11 +202,42 @@ static void mx2_gpio_irq_handler(u32 irq, struct irq_desc *desc) > } > } > > +/* > + * Set interrupt number "irq" in the GPIO as a wake-up source. > + * While system is running, all registered GPIO interrupts need to have > + * wake-up enabled. When system is suspended, only selected GPIO interrupts > + * need to have wake-up enabled. > + * @param irq interrupt source number > + * @param enable enable as wake-up if equal to non-zero > + * @return This function returns 0 on success. > + */ > +static int gpio_set_wake_irq(u32 irq, u32 enable) > +{ > + u32 gpio = irq_to_gpio(irq); > + u32 gpio_idx = gpio & 0x1F; > + struct mxc_gpio_port *port = &mxc_gpio_ports[gpio / 32]; > + > + if (enable) { > + if (port->irq_high && (gpio_idx >= 16)) > + enable_irq_wake(port->irq_high); > + else > + enable_irq_wake(port->irq); > + } else { > + if (port->irq_high && (gpio_idx >= 16)) > + disable_irq_wake(port->irq_high); > + else > + disable_irq_wake(port->irq); > + } > + > + return 0; > +} > + Is this really enough to let the CPU wake up? Is this implementation correct for all i.MX SoCs? Best regards Uwe > static struct irq_chip gpio_irq_chip = { > .ack = gpio_ack_irq, > .mask = gpio_mask_irq, > .unmask = gpio_unmask_irq, > .set_type = gpio_set_irq_type, > + .set_wake = gpio_set_wake_irq, > }; > > static void _set_gpio_direction(struct gpio_chip *chip, unsigned offset, > -- > 1.6.0.4 > > > -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |