From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Bruno Randolf <br1@einfach.org>
Cc: kosaki.motohiro@jp.fujitsu.com, randy.dunlap@oracle.com,
akpm@linux-foundation.org, peterz@infradead.org,
blp@cs.stanford.edu, linux-kernel@vger.kernel.org,
Lars_Ericsson@telia.com, kevin.granade@gmail.com
Subject: Re: [PATCH v5] Add generic exponentially weighted moving average (EWMA) function
Date: Fri, 22 Oct 2010 10:42:41 +0900 (JST) [thread overview]
Message-ID: <20101022104057.53B2.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <20101022013214.6831.25967.stgit@localhost6.localdomain6>
only one nit.
> +/**
> + * ewma_init() - Initialize EWMA parameters
> + * @avg: Average structure
> + * @factor: Factor to use for the scaled up internal value. The maximum value
> + * of averages can be UINT_MAX/(factor*weight).
ULONG_MAX?
Anyway,
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
prev parent reply other threads:[~2010-10-22 1:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 1:32 Bruno Randolf
2010-10-22 1:42 ` KOSAKI Motohiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101022104057.53B2.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=Lars_Ericsson@telia.com \
--cc=akpm@linux-foundation.org \
--cc=blp@cs.stanford.edu \
--cc=br1@einfach.org \
--cc=kevin.granade@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®