From: Andi Kleen <andi@firstfloor.org>
To: Marco Stornelli <marco.stornelli@gmail.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
x86@kernel.org, Tim Bird <tim.bird@am.sony.com>,
andi@firstfloor.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] archs: add ioremap_change_write_prot
Date: Tue, 26 Oct 2010 15:14:23 +0200 [thread overview]
Message-ID: <20101026131423.GA29961@basil.fritz.box> (raw)
In-Reply-To: <AANLkTim460pm6QNgUh+C0p=D3Ppu7Q3Dx1j2PNd7Amdr@mail.gmail.com>
> Sorry to re-open the topic, but I'd like to receive any
> comments/feedback about this patch.
The name of the wrapper seems wrong -- this has nothing to do with IO.
I must admit I'm also not a fan of wrappers, why not call the set_memory_*
functions directly and implement them for the other archs too?
Other than that it seems reasonable.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2010-10-26 13:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-24 8:41 Marco Stornelli
2010-10-26 10:56 ` Marco Stornelli
2010-10-26 13:14 ` Andi Kleen [this message]
2010-10-26 16:24 ` Thomas Gleixner
2010-10-27 6:55 ` Marco Stornelli
2010-10-27 7:59 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101026131423.GA29961@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
--cc=tim.bird@am.sony.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome