From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Greg KH <greg@kroah.com>
Cc: Manuel Stahl <manuel.stahl@iis.fraunhofer.de>,
linux-serial@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH resend] Add sc16is7x2 driver
Date: Tue, 26 Oct 2010 15:59:34 +0100 [thread overview]
Message-ID: <20101026155934.7e70a57c@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20101026145107.GA18531@kroah.com>
> > And huh, "grep -R serial_max3100.h *" gives what? Only max3100.c
> > So do we need to remove serial_max3100.h as it's not used anywhere else?
>
> Yup, that sounds like a great idea, I'll go queue up that patch when I
> get back from my travels at the moment.
Sounds a very bad idea to me. The point of the platform data objects
throughout the kernel is to allow other devices to use the driver without
having to hack it up. Removing these interfaces breaks that.
So NAK such a change. The existing code is right, the fact that the
interface isn't being used in that way visibly by currently merged code
doesn't mean it shouldn't be there.
Also max3100 has an active maintainer so perhaps you should Cc them on
such discussion ?
Alan
next prev parent reply other threads:[~2010-10-26 15:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 8:15 Manuel Stahl
2010-10-14 19:01 ` Greg KH
2010-10-15 7:24 ` Manuel Stahl
[not found] ` <20101015142709.GA18905@kroah.com>
2010-10-15 15:09 ` Manuel Stahl
2010-10-15 16:49 ` Greg KH
2010-10-18 9:46 ` Manuel Stahl
2010-10-19 15:37 ` Greg KH
2010-10-26 8:55 ` Manuel Stahl
2010-10-26 14:51 ` Greg KH
2010-10-26 14:59 ` Alan Cox [this message]
2010-10-26 19:28 ` Mark Brown
2010-11-08 14:01 ` Thomas Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101026155934.7e70a57c@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=manuel.stahl@iis.fraunhofer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®