mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: marui <m00150988@huawei.com>
Cc: Greg KH <greg@kroah.com>, Alan Stern <stern@rowland.harvard.edu>,
	USB list <linux-usb@vger.kernel.org>,
	Kernel development list <linux-kernel@vger.kernel.org>,
	zihan@huawei.com, wangyeqi@huawei.com
Subject: Re: [PATCH] fix oops in usbserial_cleanup function
Date: Wed, 27 Oct 2010 10:32:47 +0100	[thread overview]
Message-ID: <20101027103247.38d88ece@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <00a801cb75a5$faf0a680$ba260b0a@china.huawei.com>

> Oct 27 00:20:10 linux-mec9 kernel: [ 6441.999651] serial_cleanup - port 5
> Oct 27 00:20:10 linux-mec9 kernel: [ 6441.999653] destroy_serial - (null)

So someone called destroy serial with serial->type->desc NULL

> Oct 27 00:20:10 linux-mec9 kernel: [ 6441.999654] return_serial
> Oct 27 00:20:10 linux-mec9 kernel: [ 6441.999671] BUG: unable to handle kernel NULL pointer dereference at (null)
> Oct 27 00:20:10 linux-mec9 kernel: [ 6441.999675] IP: [<(null)>] (null)

And serial->type->release NULL

> Oct 27 00:20:10 linux-mec9 kernel: [ 6441.999762]  [<fb877b40>] ? destroy_serial+0x80/0xd0 [usbserial]
> Oct 27 00:20:10 linux-mec9 kernel: [ 6441.999765]  [<fb877ac0>] ? destroy_serial+0x0/0xd0 [usbserial]
> Oct 27 00:20:10 linux-mec9 kernel: [ 6441.999770]  [<c03f351a>] ? kref_put+0x2a/0x60

Which came from the tty close (which will be after the hangup if you
pulled the card out with the modem in use). Kref leak perhaps ?

What driver is actually being used for the card itself ?

Alan

  reply	other threads:[~2010-10-27  9:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-15  8:30 [PATCH] fix oops in usbserial_cleanup function; m00150988
2010-10-15 14:15 ` Alan Stern
2010-10-15 19:09   ` Greg KH
2010-10-27  7:10     ` [PATCH] fix oops in usbserial_cleanup function marui
2010-10-27  9:32       ` Alan Cox [this message]
2010-10-29  5:07         ` marui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101027103247.38d88ece@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m00150988@huawei.com \
    --cc=stern@rowland.harvard.edu \
    --cc=wangyeqi@huawei.com \
    --cc=zihan@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®