From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: Jiri Slaby <jslaby@suse.cz>,
sfrench@samba.org, linux-kernel@vger.kernel.org,
jirislaby@gmail.com, linux-cifs@vger.kernel.org
Subject: Re: [PATCH 2/4] FS: cifs, remove unneeded NULL tests
Date: Wed, 27 Oct 2010 12:14:32 -0400 [thread overview]
Message-ID: <20101027161431.GA20363@infradead.org> (raw)
In-Reply-To: <20101027121338.2984b9d8@corrin.poochiereds.net>
On Wed, Oct 27, 2010 at 12:13:38PM -0400, Jeff Layton wrote:
> > diff --git a/fs/cifs/file.c b/fs/cifs/file.c
> > index 45af003..db7eaf7 100644
> > --- a/fs/cifs/file.c
> > +++ b/fs/cifs/file.c
> > @@ -1031,7 +1031,7 @@ ssize_t cifs_user_write(struct file *file, const char __user *write_data,
> > cifs_stats_bytes_written(pTcon, total_written);
> >
> > /* since the write may have blocked check these pointers again */
> > - if ((file->f_path.dentry) && (file->f_path.dentry->d_inode)) {
> > + if (file->f_path.dentry->d_inode) {
>
> ^^^^^^
> This check is bogus too. An open filp on a negative dentry
> isn't possible, right?
Indeed, it's impossible.
prev parent reply other threads:[~2010-10-27 16:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 11:50 Jiri Slaby
2010-10-27 16:13 ` Jeff Layton
2010-10-27 16:14 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101027161431.GA20363@infradead.org \
--to=hch@infradead.org \
--cc=jirislaby@gmail.com \
--cc=jlayton@redhat.com \
--cc=jslaby@suse.cz \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®