From: Sascha Hauer <s.hauer@pengutronix.de>
To: Nguyen Dinh-R00091 <R00091@freescale.com>
Cc: "Eric Bénard" <eric@eukrea.com>,
"Grant Likely" <grant.likely@secretlab.ca>,
amit.kucheria@canonical.com, linux@arm.linux.org.uk,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, daniel@caiaq.de,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
valentin.longchamp@epfl.ch
Subject: Re: [PATCH] ARM: imx: Add some core definitions for MX53
Date: Wed, 27 Oct 2010 18:31:40 +0200 [thread overview]
Message-ID: <20101027163140.GN6017@pengutronix.de> (raw)
In-Reply-To: <86A0E76937111F4C92FABEC0A2098851051D6523@az33exm21>
On Wed, Oct 27, 2010 at 07:57:11AM -0700, Nguyen Dinh-R00091 wrote:
> >
> >Yes, I know. Is MX5_1_3 better? Any other suggestions?
>
> Not sure why we can't do something like this?
>
> In mx5x.h,
> MX51_PERIP_1 /* Address specific to mx51 */
> MX53_PERIP_1 /* Address specific to mx53 */
> MX5_PERIP_2 /* Address that is shared to mx51, mx53, and any later mx5X chips */
The problem is that we don't know about 'any later chips' and we don't
know whether the MX5_ assumption stays true for later MX5 chips.
To end this, let's just use the complete names for all i.MX defines,
that is MX51 for MX51 and MX53 for MX53. It's the only way to handle
this consistently for *all* i.MX, not only the MX5 ones.
Uwe has worked a lot on making the overhead for this as little s
possible and in the end we are just talking about a handfull of base
addresses and interrupt/dma request numbers. It should be simple to add
them without asking the question 'is this mxx specific or mxy also?'
over and over again.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2010-10-27 16:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 18:53 Dinh.Nguyen
2010-10-26 19:10 ` Uwe Kleine-König
2010-10-26 22:37 ` Nguyen Dinh-R00091
2010-10-27 8:29 ` Grant Likely
2010-10-27 9:09 ` Uwe Kleine-König
2010-10-27 10:22 ` Grant Likely
2010-10-27 13:22 ` Sascha Hauer
2010-10-27 13:33 ` Eric Bénard
2010-10-27 13:56 ` Sascha Hauer
2010-10-27 14:57 ` Nguyen Dinh-R00091
2010-10-27 16:31 ` Sascha Hauer [this message]
2010-10-27 23:44 ` Robert Schwebel
2010-10-27 13:36 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101027163140.GN6017@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=R00091@freescale.com \
--cc=amit.kucheria@canonical.com \
--cc=daniel@caiaq.de \
--cc=eric@eukrea.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=u.kleine-koenig@pengutronix.de \
--cc=valentin.longchamp@epfl.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome