Re: [GIT PULL] battery-2.6.git (a last minute fix)

[Samuel Ortiz <sameo@linux.intel.com>]

Hi Anton,

On Thu, Oct 28, 2010 at 01:09:53PM +0400, Anton Vorontsov wrote:
> On Thu, Oct 28, 2010 at 12:07:10AM -0700, Andrew Morton wrote:
> [...]
> > > The new driver does not build at its own commit point either, as the missing symbol 
> > > definition is simply not there. It appears that commit 2e727f1 could not have been 
> > > build-tested by anyone before it got upstream (let alone boot and functionality 
> > > tested). As a temporary workaround i'm disabling it in -tip.
> > > 
> > 
> > Those definitions get added by the MFD tree and used by the battery
> > tree.  Things arrived in the wrong order (and, yes, didn't get tested).
> 
> My bad. :-/
>
> > The fix is for Samuel to get a wiggle on with his merge?  The -rc1
> > window is about to slam shut on his fingers anyway.
> 
> I guess the best thing for now would be to be safe and to disable
> the new driver via 'depends on BROKEN', so it won't scare testers
> away from -rc1.
I'm about to send my pull request to Linus. Should I send this commit revert
as part of the pull request, or do you want to do it ?

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/