From: Alex Williamson <alex.williamson@redhat.com>
To: pugs@cisco.com
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
kvm@vger.kernel.org, avi@redhat.com, chrisw@redhat.com,
mst@redhat.com, alex.williamson@redhat.com
Subject: [PATCH 3/5] vfio: Add ioctl to re-enable interrupts
Date: Sat, 30 Oct 2010 10:59:38 -0600 [thread overview]
Message-ID: <20101030165929.885.47408.stgit@s20.home> (raw)
In-Reply-To: <20101030164626.885.89216.stgit@s20.home>
Clearing the INTx disable bit from userspace requires two ioctls,
we can do it from vfio with only one. This also better defines the
API and allows us to support non-PCI-2.3 compliant devices.
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
drivers/vfio/vfio_intrs.c | 17 +++++++++++++++++
drivers/vfio/vfio_main.c | 4 ++++
include/linux/vfio.h | 3 +++
3 files changed, 24 insertions(+), 0 deletions(-)
diff --git a/drivers/vfio/vfio_intrs.c b/drivers/vfio/vfio_intrs.c
index aaee175..a57d5aa 100644
--- a/drivers/vfio/vfio_intrs.c
+++ b/drivers/vfio/vfio_intrs.c
@@ -83,6 +83,23 @@ done:
return ret;
}
+int vfio_irq_eoi(struct vfio_dev *vdev)
+{
+ struct pci_dev *pdev = vdev->pdev;
+ u16 cmd;
+
+ spin_lock_irq(&vdev->irqlock);
+ pci_block_user_cfg_access(pdev);
+
+ pci_read_config_word(pdev, PCI_COMMAND, &cmd);
+ cmd &= ~PCI_COMMAND_INTX_DISABLE;
+ pci_write_config_word(pdev, PCI_COMMAND, cmd);
+
+ pci_unblock_user_cfg_access(pdev);
+ spin_unlock_irq(&vdev->irqlock);
+ return 0;
+}
+
/*
* MSI and MSI-X Interrupt handler.
* Just signal an event
diff --git a/drivers/vfio/vfio_main.c b/drivers/vfio/vfio_main.c
index f671795..72db79c 100644
--- a/drivers/vfio/vfio_main.c
+++ b/drivers/vfio/vfio_main.c
@@ -464,6 +464,10 @@ static long vfio_unl_ioctl(struct file *filep,
ret = vfio_domain_unset(vdev);
break;
+ case VFIO_IRQ_EOI:
+ ret = vfio_irq_eoi(vdev);
+ break;
+
default:
return -EINVAL;
}
diff --git a/include/linux/vfio.h b/include/linux/vfio.h
index c491180..73d7e84 100644
--- a/include/linux/vfio.h
+++ b/include/linux/vfio.h
@@ -155,6 +155,7 @@ void vfio_error_resume(struct pci_dev *);
#define VFIO_SUSPEND_REPLY_TIMEOUT (5*HZ)
irqreturn_t vfio_interrupt(int, void *);
+int vfio_irq_eoi(struct vfio_dev *);
#endif /* __KERNEL__ */
@@ -198,6 +199,8 @@ struct vfio_dma_map {
/* Unset the IOMMU domain */
#define VFIO_DOMAIN_UNSET _IO(';', 108)
+/* Re-enable INTx */
+#define VFIO_IRQ_EOI _IO(';', 109)
/*
* Reads, writes, and mmaps determine which PCI BAR (or config space)
* from the high level bits of the file offset
next prev parent reply other threads:[~2010-10-30 16:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-30 16:58 [PATCH 0/5] Fixes, non-PCI-2.3 support, EOI enhancements Alex Williamson
2010-10-30 16:59 ` [PATCH 1/5] vfio: Fix the ROM mask Alex Williamson
2010-10-30 16:59 ` [PATCH 2/5] vfio: Fix requested regions Alex Williamson
2010-10-30 16:59 ` Alex Williamson [this message]
2010-10-30 16:59 ` [PATCH 4/5] vfio: Add support for non-PCI 2.3 compliant devices Alex Williamson
2010-10-30 16:59 ` [PATCH 5/5] vfio: Add a new ioctl to support EOI via eventfd Alex Williamson
2010-11-01 21:22 ` [PATCH 0/5] Fixes, non-PCI-2.3 support, EOI enhancements Tom Lyon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101030165929.885.47408.stgit@s20.home \
--to=alex.williamson@redhat.com \
--cc=avi@redhat.com \
--cc=chrisw@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pugs@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome