From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758210Ab0KAPuJ (ORCPT ); Mon, 1 Nov 2010 11:50:09 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:42436 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756831Ab0KAPuH (ORCPT ); Mon, 1 Nov 2010 11:50:07 -0400 Date: Mon, 01 Nov 2010 08:50:30 -0700 (PDT) Message-Id: <20101101.085030.226787287.davem@davemloft.net> To: sfr@canb.auug.org.au Cc: jwboyer@gmail.com, rsarmah@apm.com, therbert@google.com, eric.dumazet@gmail.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: All Applied micro boards are failing with current mainline kernel From: David Miller In-Reply-To: <20101102023650.bc553e74.sfr@canb.auug.org.au> References: <20101102023650.bc553e74.sfr@canb.auug.org.au> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stephen Rothwell Date: Tue, 2 Nov 2010 02:36:50 +1100 > Hi Josh, > > On Mon, 1 Nov 2010 11:05:53 -0400 Josh Boyer wrote: >> >> A few hints would be appreciated. > > Remove the call to netif_stop_queue() from emac_probe(). Apparently, > calling this before register_netdev() is now wrong (maybe always was). Right. I'll add this to net-2.6 -------------------- ibm_newemac: Remove netif_stop_queue() in emac_probe(). Touching the queue state before register_netdev is not allowed, and besides the queue state before ->open() is "don't care" Reported-by: Josh Boyer Reported-by: Stephen Rothwell Signed-off-by: David S. Miller --- drivers/net/ibm_newemac/core.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c index 385dc32..06bb9b7 100644 --- a/drivers/net/ibm_newemac/core.c +++ b/drivers/net/ibm_newemac/core.c @@ -2871,7 +2871,6 @@ static int __devinit emac_probe(struct platform_device *ofdev, SET_ETHTOOL_OPS(ndev, &emac_ethtool_ops); netif_carrier_off(ndev); - netif_stop_queue(ndev); err = register_netdev(ndev); if (err) { -- 1.7.3.2