From: Hans Verkuil <hverkuil@xs4all.nl>
To: Axel Lin <axel.lin@gmail.com>
Cc: "linux-kernel" <linux-kernel@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH] V4L/DVB: tea6415c: return -EIO if i2c_check_functionality fails
Date: Mon, 1 Nov 2010 14:13:37 +0100 [thread overview]
Message-ID: <201011011413.37411.hverkuil@xs4all.nl> (raw)
In-Reply-To: <1288603539.3831.2.camel@mola>
On Monday, November 01, 2010 10:25:39 Axel Lin wrote:
> If the adapter does not support I2C_FUNC_SMBUS_WRITE_BYTE,
> return -EIO instead of 0.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Hans Verkuil <hverkuil@xs4all.nl>
> ---
> drivers/media/video/tea6415c.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/video/tea6415c.c b/drivers/media/video/tea6415c.c
> index 3e99cea..19621ed 100644
> --- a/drivers/media/video/tea6415c.c
> +++ b/drivers/media/video/tea6415c.c
> @@ -148,7 +148,7 @@ static int tea6415c_probe(struct i2c_client *client,
>
> /* let's see whether this adapter can support what we need */
> if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_WRITE_BYTE))
> - return 0;
> + return -EIO;
>
> v4l_info(client, "chip found @ 0x%x (%s)\n",
> client->addr << 1, client->adapter->name);
>
--
Hans Verkuil - video4linux developer - sponsored by Cisco
prev parent reply other threads:[~2010-11-01 13:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-01 9:25 Axel Lin
2010-11-01 13:13 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011011413.37411.hverkuil@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®