From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754895Ab0KAVQG (ORCPT ); Mon, 1 Nov 2010 17:16:06 -0400 Received: from ksp.mff.cuni.cz ([195.113.26.206]:58762 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751156Ab0KAVQE (ORCPT ); Mon, 1 Nov 2010 17:16:04 -0400 Date: Mon, 1 Nov 2010 22:15:49 +0100 From: Pavel Machek To: Pekka Enberg Cc: gregkh@suse.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] w35und: Kill empty Mds_Destroy function Message-ID: <20101101211549.GE22934@elf.ucw.cz> References: <1288643371-10310-1-git-send-email-penberg@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1288643371-10310-1-git-send-email-penberg@kernel.org> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 2010-11-01 22:29:28, Pekka Enberg wrote: > The Mds_Destroy() function doesn't do anything so kill it. > > Cc: Pavel Machek > Signed-off-by: Pekka Enberg ACK. > --- > drivers/staging/winbond/mds.c | 5 ----- > drivers/staging/winbond/mds_f.h | 1 - > drivers/staging/winbond/wbusb.c | 2 -- > 3 files changed, 0 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/winbond/mds.c b/drivers/staging/winbond/mds.c > index 9ac2c87..90f2cc0 100644 > --- a/drivers/staging/winbond/mds.c > +++ b/drivers/staging/winbond/mds.c > @@ -18,11 +18,6 @@ Mds_initial(struct wbsoft_priv *adapter) > return hal_get_tx_buffer(&adapter->sHwData, &pMds->pTxBuffer); > } > > -void > -Mds_Destroy(struct wbsoft_priv *adapter) > -{ > -} > - > static void Mds_DurationSet(struct wbsoft_priv *adapter, struct wb35_descriptor *pDes, u8 *buffer) > { > struct T00_descriptor *pT00; > diff --git a/drivers/staging/winbond/mds_f.h b/drivers/staging/winbond/mds_f.h > index d902843..ce8be07 100644 > --- a/drivers/staging/winbond/mds_f.h > +++ b/drivers/staging/winbond/mds_f.h > @@ -5,7 +5,6 @@ > #include "core.h" > > unsigned char Mds_initial(struct wbsoft_priv *adapter); > -void Mds_Destroy(struct wbsoft_priv *adapter); > void Mds_Tx(struct wbsoft_priv *adapter); > void Mds_SendComplete(struct wbsoft_priv *adapter, struct T02_descriptor *pt02); > void Mds_MpduProcess(struct wbsoft_priv *adapter, struct wb35_descriptor *prxdes); > diff --git a/drivers/staging/winbond/wbusb.c b/drivers/staging/winbond/wbusb.c > index df055ab..82040f4 100644 > --- a/drivers/staging/winbond/wbusb.c > +++ b/drivers/staging/winbond/wbusb.c > @@ -863,8 +863,6 @@ static void hal_halt(struct hw_data *pHwData) > > static void wb35_hw_halt(struct wbsoft_priv *adapter) > { > - Mds_Destroy(adapter); > - > /* Turn off Rx and Tx hardware ability */ > hal_stop(&adapter->sHwData); > #ifdef _PE_USB_INI_DUMP_ -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html