From: Francois Romieu <romieu@fr.zoreil.com>
To: Daniel J Blueman <daniel.blueman@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [2.6.37-rc1, patch] r8169: fix sleeping while holding spinlock...
Date: Tue, 2 Nov 2010 00:46:30 +0100 [thread overview]
Message-ID: <20101101234630.GA12106@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <AANLkTimZvwdY8Q+=iGMC2MhPt_Vow38a0SE9g4ij-cRe@mail.gmail.com>
Daniel J Blueman <daniel.blueman@gmail.com> :
> Recent changes to the r8169 driver cause it to call
> device_set_wakeup_enable under spinlock, which may sleep.
The change is fine but the description is misleading : the r8169
driver has been issuing device_set_wakeup_enable under spinlock since
october 2008. device_set_wakeup_enable did not sleep until recently
(see f2dc0d1809ab7e0147c7e4ac837be1682f706538 for instance).
drivers/net/gianfar_ethtool.c::gfar_set_wol is broken as well when
CONFIG_PM is set.
--
Ueimor
next prev parent reply other threads:[~2010-11-01 23:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-01 21:35 Daniel J Blueman
2010-11-01 23:46 ` Francois Romieu [this message]
2010-11-02 0:17 ` [2.6.37-rc1, patch v2] " Daniel J Blueman
2010-11-02 3:45 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101101234630.GA12106@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=daniel.blueman@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®