mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: prevent SAK to kill init process
Date: Tue, 2 Nov 2010 09:55:36 +0100	[thread overview]
Message-ID: <20101102085536.GB1871@jolsa.brq.redhat.com> (raw)
In-Reply-To: <m1zktszvba.fsf@fess.ebiederm.org>

On Mon, Nov 01, 2010 at 12:40:41PM -0700, Eric W. Biederman wrote:
> Jiri Olsa <jolsa@redhat.com> writes:
> 
> > hi,
> >
> > hitting "Secure Attention Key" on console that's openned
> > by init process, causing panic due to an attempt to kill
> > the init process.
> >
> > Fixing this by skipping the init process in the loop.
> 
> This sounds like proper behavior.  The goal of SAK is the guarantee that
> no one else has the tty one, and this violates that goal.  Which version
> init opens a controlling tty?  I expect it is time to deliver SIGCLUE
> to it.
I was using some older upstart version, which kept the console open

I found this log entry in changelog :)

       * No longer holds /dev/console open, so the SAK SysRq key will not
         kill Upstart.  (Bug: #486005)

So probably no need for the patch

sry for noise,
jirka

      reply	other threads:[~2010-11-02  8:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-01 18:34 Jiri Olsa
2010-11-01 19:40 ` Eric W. Biederman
2010-11-02  8:55   ` Jiri Olsa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101102085536.GB1871@jolsa.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®