From: David Sterba <dsterba@suse.cz>
To: linux-usb@vger.kernel.org
Cc: sarah.a.sharp@linux.intel.com, linux-kernel@vger.kernel.org
Subject: [PATCH] USB: xhci: Use GFP_ATOMIC under spin_lock
Date: Tue, 2 Nov 2010 23:47:18 +0100 [thread overview]
Message-ID: <20101102224718.GB27513@ds.suse.cz> (raw)
coccinelle check scripts/coccinelle/locks/call_kern.cocci found that
in drivers/usb/host/xhci.c an allocation with GFP_KERNEL is done
with locks held:
xhci_resume
spin_lock_irq(xhci->lock)
xhci_setup_msix
kmalloc(GFP_KERNEL)
Change it to GFP_ATOMIC.
Signed-off-by: David Sterba <dsterba@suse.cz>
CC: Sarah Sharp <sarah.a.sharp@linux.intel.com>
---
Exists in v2.6.37-rc1 and current linux-next
diff -u -p a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
--- a/drivers/usb/host/xhci.c 2010-10-27 11:27:23.534310054 +0200
+++ b/drivers/usb/host/xhci.c 2010-11-02 15:53:03.000000000 +0100
@@ -240,7 +240,7 @@ static int xhci_setup_msix(struct xhci_h
xhci->msix_entries =
kmalloc((sizeof(struct msix_entry))*xhci->msix_count,
- GFP_KERNEL);
+ GFP_ATOMIC);
if (!xhci->msix_entries) {
xhci_err(xhci, "Failed to allocate MSI-X entries\n");
return -ENOMEM;
next reply other threads:[~2010-11-02 22:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 22:47 David Sterba [this message]
[not found] ` <4CD11AF7.309@suse.cz>
2010-11-04 15:03 ` Sarah Sharp
2010-11-04 15:09 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101102224718.GB27513@ds.suse.cz \
--to=dsterba@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®