From: Mike Waychison <mikew@google.com>
To: simon.kagstrom@netinsight.net, davem@davemloft.net
Cc: adurbin@google.com, akpm@linux-foundation.org, chavey@google.com,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org
Subject: [PATCH v1 06/12] netoops: Add x86 specific bits to packet headers
Date: Tue, 02 Nov 2010 18:30:01 -0700 [thread overview]
Message-ID: <20101103013000.4641.50991.stgit@crlf.mtv.corp.google.com> (raw)
In-Reply-To: <20101103012917.4641.57113.stgit@crlf.mtv.corp.google.com>
We need to be able to gather information about the CPUs that caused the crash.
This commit only handles x86, but it is desirable to come up with some new
packet format that can accommodate any architecture.
Signed-off-by: Mike Waychison <mikew@google.com>
---
TODO: This should be made more general to other architectures. As is, we are
probably okay exporting some value for the 'arch' field. Different
architectures though will likely want to gather different data.
---
drivers/net/netoops.c | 30 +++++++++++++++++++++++-------
1 files changed, 23 insertions(+), 7 deletions(-)
diff --git a/drivers/net/netoops.c b/drivers/net/netoops.c
index e9fdda3..0865212 100644
--- a/drivers/net/netoops.c
+++ b/drivers/net/netoops.c
@@ -55,16 +55,24 @@ struct netoops_msg {
u32 packet_count;
u32 packet_no;
u32 __reserved1;
- u8 __reserved2;
- u8 __reserved3;
- u8 __reserved4;
+ u8 x86_family;
+ u8 x86_model;
+ u8 x86_stepping;
/*
* NOTE: fixed length strings for a packet. NULL
* termination not required.
*/
char kernel_version[64];
- char __reserved5[64];
- char __reserved6[64];
+ char __reserved2[64];
+ char __reserved3[64];
+ /* NOTE: regs is 60 or 168 bytes */
+ struct pt_regs regs; /* arch specific. */
+ /*
+ * NOTE: The header is potentially ~385 bytes
+ * already. That doesn't leave much room for
+ * expansion unless we reduce the data size
+ * or truncate above fields.
+ */
} __attribute__ ((packed)) header;
char data[NETOOPS_DATA_BYTES];
} __attribute__ ((packed));
@@ -302,7 +310,8 @@ static void get_netoops_dest(char *buff, int buffsize, u32 *dest, u32 *src)
spin_unlock_irqrestore(&netoops_lock, flags);
}
-static void setup_packet_header(int packet_count, int soft_dump)
+static void setup_packet_header(int packet_count, struct pt_regs *regs,
+ int soft_dump)
{
msg.header.version = NETOOPS_VERSION;
msg.header.arch = NETOOPS_ARCH;
@@ -311,10 +320,17 @@ static void setup_packet_header(int packet_count, int soft_dump)
msg.header.dump_id = (jiffies/HZ) & 0xffff;
msg.header.packet_count = packet_count;
msg.header.header_size = sizeof(msg.header);
+#ifndef CONFIG_UML
+ msg.header.x86_family = current_cpu_data.x86;
+ msg.header.x86_model = current_cpu_data.x86_model;
+ msg.header.x86_stepping = current_cpu_data.x86_mask;
+#endif
strncpy(msg.header.kernel_version,
utsname()->release,
min(sizeof(msg.header.kernel_version),
sizeof(utsname()->release)));
+ if (regs != NULL)
+ memcpy(&msg.header.regs, regs, sizeof(msg.header.regs));
}
static int packet_count_from_length(unsigned long l)
@@ -403,7 +419,7 @@ static void netoops(struct kmsg_dumper *dumper, enum kmsg_dump_reason reason,
/* setup the non varying parts of the message */
memset(&msg, 0, sizeof(msg));
- setup_packet_header(packet_count_1 + packet_count_2, soft_dump);
+ setup_packet_header(packet_count_1 + packet_count_2, regs, soft_dump);
/* Transmission loop */
for (i = 0; i < NETOOPS_RETRANSMIT_COUNT; i++) {
next prev parent reply other threads:[~2010-11-03 1:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-03 1:29 [PATCH v1 00/12] netoops support Mike Waychison
2010-11-03 1:29 ` [PATCH v1 01/12] Oops: Pass regs to oops_exit() Mike Waychison
2010-11-03 1:29 ` [PATCH v1 02/12] kmsg_dumper: Pass pt_regs along to dumpers Mike Waychison
2010-11-03 1:29 ` [PATCH v1 03/12] kmsg_dumper: Introduce a new 'SOFT' dump reason Mike Waychison
2010-11-03 1:29 ` [PATCH v1 04/12] sys-rq: Add option to soft dump Mike Waychison
2010-11-03 1:29 ` [PATCH v1 05/12] netoops: add core functionality Mike Waychison
2010-11-03 1:30 ` Mike Waychison [this message]
2010-11-03 1:30 ` [PATCH v1 07/12] netoops: Add user programmable fields to the netoops packet Mike Waychison
2010-11-03 1:30 ` [PATCH v1 08/12] netoops: Add one-shot mode Mike Waychison
2010-11-03 1:30 ` [PATCH v1 09/12] netoops: Add an interface to trigger various types of crashes Mike Waychison
2010-11-03 1:30 ` [PATCH v1 10/12] kmsg_dump: Export symbol kmsg_dump() to GPL modules Mike Waychison
2010-11-03 1:30 ` [PATCH v1 11/12] ipv4: Export arp_bind_neighbour() symbol " Mike Waychison
2010-11-03 1:30 ` [PATCH v1 12/12] netoops: Allow the driver to be built as a module Mike Waychison
2010-11-03 2:34 ` [PATCH v1 00/12] netoops support Greg KH
2010-11-03 3:37 ` Mike Waychison
2010-11-03 18:16 ` Greg KH
2010-11-03 18:50 ` Randy Dunlap
2010-11-03 19:40 ` Joe Perches
2010-11-03 20:58 ` Bruno Prémont
2010-11-03 19:03 ` Mike Waychison
2010-11-03 20:29 ` Mike Waychison
2010-11-03 20:54 ` Matt Mackall
2010-11-04 1:18 ` Mike Waychison
2010-11-04 6:35 ` Américo Wang
2010-11-04 17:38 ` Mike Waychison
2010-11-04 6:15 ` Américo Wang
2010-11-04 17:21 ` Mike Waychison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101103013000.4641.50991.stgit@crlf.mtv.corp.google.com \
--to=mikew@google.com \
--cc=adurbin@google.com \
--cc=akpm@linux-foundation.org \
--cc=chavey@google.com \
--cc=davem@davemloft.net \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=simon.kagstrom@netinsight.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®