From: Brandon Philips <brandon@ifup.org>
To: Marek Belisko <marek.belisko@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/9] staging: ft1000: Get rid of BOOLEAN typedef usage.
Date: Wed, 3 Nov 2010 07:57:13 -0700 [thread overview]
Message-ID: <20101103145713.GA2000@jenkins.mit.edu> (raw)
In-Reply-To: <1288779595-15793-7-git-send-email-marek.belisko@gmail.com>
On 11:19 Wed 03 Nov 2010, Marek Belisko wrote:
> - BOOLEAN bGoodVersion;
> + u8 bGoodVersion;
Please use the bool type instead of u8. Might as well do FALSE/TRUE ->
false/true while you are at it :)
Cheers,
Brandon
next prev parent reply other threads:[~2010-11-03 14:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-03 10:19 [PATCH 1/9] staging: ft1000: Get rid of PUCHAR typedef Marek Belisko
2010-11-03 10:19 ` [PATCH 2/9] staging: ft1000: Get rid of UCHAR typedef Marek Belisko
2010-11-03 10:19 ` [PATCH 3/9] staging: ft1000: GEt rid of PUSHORT typedef usage Marek Belisko
2010-11-03 10:19 ` [PATCH 4/9] staging: ft1000: Get rid of USHORT " Marek Belisko
2010-11-03 10:19 ` [PATCH 5/9] staging: ft1000: Get rid of PULONG " Marek Belisko
2010-11-03 10:19 ` [PATCH 6/9] staging: ft1000: Get rid of ULONG " Marek Belisko
2010-11-03 10:19 ` [PATCH 7/9] staging: ft1000: Get rid of BOOLEAN " Marek Belisko
2010-11-03 14:57 ` Brandon Philips [this message]
2010-11-04 6:58 ` Belisko Marek
2010-11-03 10:19 ` [PATCH 8/9] staging: ft1000: Get rid of PCHAR " Marek Belisko
2010-11-03 10:19 ` [PATCH 9/9] staging: ft1000: Get rid of UINT " Marek Belisko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101103145713.GA2000@jenkins.mit.edu \
--to=brandon@ifup.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®