From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753111Ab0KFTED (ORCPT ); Sat, 6 Nov 2010 15:04:03 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:60099 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752612Ab0KFTEB (ORCPT ); Sat, 6 Nov 2010 15:04:01 -0400 Date: Sat, 6 Nov 2010 15:03:58 -0400 From: Christoph Hellwig To: "J. Bruce Fields" Cc: Christoph Hellwig , Arnd Bergmann , Linus Torvalds , Bryan Schumaker , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] locks: let the caller free file_lock on ->setlease failure Message-ID: <20101106190358.GB15850@infradead.org> References: <20101027133924.GB6328@fieldses.org> <201010271546.09036.arnd@arndb.de> <20101027145538.GC6328@fieldses.org> <20101027145929.GA5788@infradead.org> <20101030212500.GE480@fieldses.org> <20101031123419.GA4491@infradead.org> <20101031123510.GA4520@infradead.org> <20101103204147.GA6777@fieldses.org> <20101104014024.GA22498@fieldses.org> <20101104014128.GB22498@fieldses.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101104014128.GB22498@fieldses.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > A minor oversight from f7347ce4ee7c65415f84be915c018473e7076f31, > "fasync: re-organize fasync entry insertion to allow it under a > spinlock": this cleanup-on-error was only needed to handle -ENOMEM. Now > that we're preallocating it's unneeded. Looks good to me, too.