From: Frank Mori Hess <fmhess@speakeasy.net>
To: Jesper Juhl <jj@chaosbits.net>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
Gustavo Silva <silvagustavo@users.sourceforge.net>,
Tejun Heo <tj@kernel.org>, Arun Thomas <arun.thomas@gmail.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Frank Mori Hess <fmhess@users.sourceforge.net>,
"Chris R. Baugher" <baugher@enteract.com>,
"David A. Schleef" <ds@schleef.org>
Subject: Re: [PATCH] staging, comedi, das16: das16_attach() needs to free allocated resources on failure
Date: Sun, 7 Nov 2010 18:35:23 -0500 [thread overview]
Message-ID: <201011071835.28692.fmhess@speakeasy.net> (raw)
In-Reply-To: <alpine.LNX.2.00.1011072126150.26247@swampdragon.chaosbits.net>
[-- Attachment #1: Type: text/plain, Size: 429 bytes --]
On Sunday 07 November 2010, Jesper Juhl wrote:
> Hi,
>
> In drivers/staging/comedi/drivers/das16.c::das16_attach() there are many
> potential failure scenarios. However, the driver neglects to free
> resources it has allocated if failures happen.
This patch appears to be wrong. The driver's detach function will be
called by the core if the attach function returns with an error. The
resources are freed there.
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2010-11-07 23:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-07 20:32 Jesper Juhl
2010-11-07 23:35 ` Frank Mori Hess [this message]
2010-11-07 23:34 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011071835.28692.fmhess@speakeasy.net \
--to=fmhess@speakeasy.net \
--cc=arun.thomas@gmail.com \
--cc=baugher@enteract.com \
--cc=devel@driverdev.osuosl.org \
--cc=ds@schleef.org \
--cc=fmhess@users.sourceforge.net \
--cc=gregkh@suse.de \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=silvagustavo@users.sourceforge.net \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®