From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Marek Belisko <marek.belisko@gmail.com>
Cc: Vincent Sanders <support@simtec.co.uk>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: touchscreen: s3c2410: Add ABS_PRESSURE event sending.
Date: Tue, 9 Nov 2010 07:54:55 -0800 [thread overview]
Message-ID: <20101109155455.GA3682@core.coreip.homeip.net> (raw)
In-Reply-To: <1289307616-10336-1-git-send-email-marek.belisko@gmail.com>
On Tue, Nov 09, 2010 at 02:00:16PM +0100, Marek Belisko wrote:
> This patch add sending of event ABS_PRESSURE for
> s3c24xx touchscreen.
>
> Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
> ---
> drivers/input/touchscreen/s3c2410_ts.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/touchscreen/s3c2410_ts.c b/drivers/input/touchscreen/s3c2410_ts.c
> index 8feb7f3..a937105 100644
> --- a/drivers/input/touchscreen/s3c2410_ts.c
> +++ b/drivers/input/touchscreen/s3c2410_ts.c
> @@ -126,6 +126,7 @@ static void touch_timer_fire(unsigned long data)
> input_report_abs(ts.input, ABS_Y, ts.yp);
>
> input_report_key(ts.input, BTN_TOUCH, 1);
> + input_report_abs(ts.input, ABS_PRESSURE, 1);
No, if device does not provide true pressure readings it should not send
ABS_PRESSURE events. Please fix your userspace.
Thanks.
--
Dmitry
prev parent reply other threads:[~2010-11-09 15:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 13:00 Marek Belisko
2010-11-09 15:54 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101109155455.GA3682@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@gmail.com \
--cc=support@simtec.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome