mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: pjt@google.com
Cc: linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
	mingo@elte.hu, vatsa@in.ibm.com, cfriesen@nortel.com,
	svaidy@linux.vnet.ibm.com, pbourdon@excellency.fr,
	bharata@linux.vnet.ibm.com, kmr@us.ibm.com,
	balbir@linux.vnet.ibm.com
Subject: Re: [tg_shares_up rewrite v2 10/11] sched: allow update_cfs_load to update global load
Date: Wed, 10 Nov 2010 20:50:01 -0800 (PST)	[thread overview]
Message-ID: <20101110.205001.226775444.davem@davemloft.net> (raw)
In-Reply-To: <20101110.204704.193706279.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Wed, 10 Nov 2010 20:47:04 -0800 (PST)

> From: Paul Turner <pjt@google.com>
> Date: Wed, 10 Nov 2010 19:50:15 -0800
> 
>> Refactor the global load updates from update_shares_cpu() so that
>> update_cfs_load() can update global load when it is more than ~10% out of sync.
>> 
>> The new global_load parameter allows us to force an update, regardless of
>> the error factor so that we can synchronize w/ update_shares().
>> 
>> Signed-off-by: Paul Turner <pjt@google.com>
> 
> This patch breaks the build, you didn't update the arguments of
> update_cfs_load() in the !CONFIG_FAIR_GROUP_SCHED case.

And even with this fixed there are even larger problems, as you're
making access to structure members such as 'load_unacc_exec_time'
which only exist when CONFIG_FAIR_GROUP_SCHED is set, but you're doing
it in code that is built unconditionally.

Please fix all of these build problems, as I want to test your changes
without all of the group scheduler bloat turned on.

Thanks.

  reply	other threads:[~2010-11-11  4:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-11  3:50 [tg_shares_up rewrite v2 00/11] reducing overhead for tg->shares distribution Paul Turner
2010-11-11  3:50 ` [tg_shares_up rewrite v2 01/11] sched: rewrite tg_shares_up Paul Turner
2010-11-11  3:50 ` [tg_shares_up rewrite v2 02/11] sched: on-demand (active) cfs_rq list Paul Turner
2010-11-11  3:50 ` [tg_shares_up rewrite v2 03/11] sched: make tg_shares_up() walk on-demand Paul Turner
2010-11-11  3:50 ` [tg_shares_up rewrite v2 04/11] sched: fix load corruption from update_cfs_shares Paul Turner
2010-11-11  3:50 ` [tg_shares_up rewrite v2 05/11] sched: fix update_cfs_load synchronization Paul Turner
2010-11-11  3:50 ` [tg_shares_up rewrite v2 06/11] sched: hierarchal order on shares update list Paul Turner
2010-11-11  3:50 ` [tg_shares_up rewrite v2 07/11] sched: add sysctl_sched_shares_window Paul Turner
2010-11-11  3:50 ` [tg_shares_up rewrite v2 08/11] sched: update shares on idle_balance Paul Turner
2010-11-11  3:50 ` [tg_shares_up rewrite v2 09/11] sched: demand based update_cfs_load() Paul Turner
2010-11-11  3:50 ` [tg_shares_up rewrite v2 10/11] sched: allow update_cfs_load to update global load Paul Turner
2010-11-11  4:47   ` David Miller
2010-11-11  4:50     ` David Miller [this message]
2010-11-11 11:13       ` Paul Turner
2010-11-11 12:37       ` Peter Zijlstra
2010-11-11  3:50 ` [tg_shares_up rewrite v2 11/11] sched: update tg->shares after cpu.shares write Paul Turner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101110.205001.226775444.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=a.p.zijlstra@chello.nl \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=bharata@linux.vnet.ibm.com \
    --cc=cfriesen@nortel.com \
    --cc=kmr@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pbourdon@excellency.fr \
    --cc=pjt@google.com \
    --cc=svaidy@linux.vnet.ibm.com \
    --cc=vatsa@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®