mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Jesper Juhl <jj@chaosbits.net>
Cc: linux-kernel@vger.kernel.org,
	Randy Dunlap <randy.dunlap@oracle.com>,
	devel@driverdev.osuosl.org, Dan Carpenter <error27@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Stephen Hemminger <shemminger@vyatta.com>
Subject: Re: [PATCH 10/17][trivial] staging, bcm: Remove unnecessary casts of void ptr returning alloc function return values
Date: Tue, 9 Nov 2010 16:45:43 -0800	[thread overview]
Message-ID: <20101110004543.GA28373@kroah.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1011082342560.23697@swampdragon.chaosbits.net>

On Tue, Nov 09, 2010 at 12:09:51AM +0100, Jesper Juhl wrote:
> Hi,
> 
> The [vk][cmz]alloc(_node) family of functions return void pointers which
> it's completely unnecessary/pointless to cast to other pointer types since
> that happens implicitly.
> 
> This patch removes such casts from drivers/staging/bcm/
> 
> 
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
>  CmHost.c       |    2 +-
>  InterfaceDld.c |   27 +++++++++++++--------------
>  Misc.c         |   12 +++++-------
>  3 files changed, 19 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c

This driver just got a major overhaul, and this patch doesn't apply
anymore.

Care to redo it against the next linux-next tree?

thanks,

greg k-h

  reply	other threads:[~2010-11-10  0:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-08 23:09 Jesper Juhl
2010-11-10  0:45 ` Greg KH [this message]
2010-11-10  8:12   ` Jesper Juhl
2010-11-10 20:31   ` Jesper Juhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101110004543.GA28373@kroah.com \
    --to=greg@kroah.com \
    --cc=arnd@arndb.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=error27@gmail.com \
    --cc=gregkh@suse.de \
    --cc=jj@chaosbits.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome