From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Minkyu Kang <promsoft@gmail.com>
Cc: Greg KH <greg@kroah.com>, Minkyu Kang <mk7.kang@samsung.com>,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
kyungmin.park@samsung.com, Ben Dooks <ben-i2c@fluff.org>
Subject: Re: [PATCH v2] misc: adds support the FSA9480 USB Switch
Date: Wed, 10 Nov 2010 14:31:10 +0000 [thread overview]
Message-ID: <20101110143110.GA5043@sirena.org.uk> (raw)
In-Reply-To: <AANLkTi=vTkHJJ2dq5RZHHCwWYEBtY=Y7dPPh=Wzzx95f@mail.gmail.com>
On Wed, Nov 10, 2010 at 09:55:34AM +0900, Minkyu Kang wrote:
> Dear Greg KH,
> > And why are you exporting symbols from this driver, that should not be
> > needed at all.
> It's for other drivers.
> For example.. When USB cable is connected, PMIC driver enable the
> power for each device. (USB, uart, audio and so on..)
> But if use the manual switch, PMIC driver can't know what device is enabled.
> So, this function was exported.
This seems like it would require the PMIC driver to have knowledge of
the USB switch driver which would be likely to give a system which is
rather board specific. For PMIC supply management integration the
regulator API would be more normal.
next prev parent reply other threads:[~2010-11-10 14:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-31 10:28 [PATCH] " Minkyu Kang
2010-09-17 22:07 ` Andrew Morton
2010-09-17 22:44 ` Greg KH
2010-09-18 1:37 ` Ben Dooks
2010-09-18 2:47 ` Kyungmin Park
2010-09-28 5:58 ` Minkyu Kang
2010-10-11 1:32 ` [PATCH v2] " Minkyu Kang
2010-10-11 17:36 ` Greg KH
2010-11-10 0:55 ` Minkyu Kang
2010-11-10 14:31 ` Mark Brown [this message]
2010-11-10 17:49 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101110143110.GA5043@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=akpm@linux-foundation.org \
--cc=ben-i2c@fluff.org \
--cc=greg@kroah.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mk7.kang@samsung.com \
--cc=promsoft@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome