mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Christoph Hellwig <hch@infradead.org>,
	Dave Chinner <david@fromorbit.com>,
	mst@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [2.6.37-rc1, OOM] virtblk: OOM in do_virtblk_request()
Date: Thu, 11 Nov 2010 07:52:54 -0500	[thread overview]
Message-ID: <20101111125254.GB11194@infradead.org> (raw)
In-Reply-To: <201011111116.48263.rusty@rustcorp.com.au>

On Thu, Nov 11, 2010 at 11:16:48AM +1030, Rusty Russell wrote:
> On Thu, 11 Nov 2010 12:01:51 am Christoph Hellwig wrote:
> > Rusty, Michael,
> > 
> > any comments?  I think Dave's observation is correct, and the lack of
> > a mempool for allocations in the virtio stack is a no-go for virtio_blk.
> 
> Interesting.  virtio will try to fall back to using direct ring entries
> if it can, but if course if your request is too large it can never do that.
> 
> So, we could add a memory pool, or restrict the request size in virtio_blk.

The mempool looks like the more generic solution.  Especially as people
are still talking about swap over nfs, at which point virtio-net will
show the same issue (just even harder to reproduce)


  reply	other threads:[~2010-11-11 12:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-05  1:30 Dave Chinner
2010-11-10 13:31 ` Christoph Hellwig
2010-11-10 15:26   ` Michael S. Tsirkin
2010-11-11  0:46   ` Rusty Russell
2010-11-11 12:52     ` Christoph Hellwig [this message]
2010-11-11 13:15       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101111125254.GB11194@infradead.org \
    --to=hch@infradead.org \
    --cc=david@fromorbit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®