From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Lighthart, EricX" <ericx.lighthart@intel.com>
Cc: "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"pb@handhelds.org" <pb@handhelds.org>,
"ext-mika.1.westerberg@nokia.com"
<ext-mika.1.westerberg@nokia.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] input: Add sysfs interface to on/off state of GPIO keys and switches
Date: Thu, 11 Nov 2010 14:15:46 +0000 [thread overview]
Message-ID: <20101111141545.GB5043@sirena.org.uk> (raw)
In-Reply-To: <E559D19195578B4E9ECB3919FF99F9792A585A8BB1@orsmsx509.amr.corp.intel.com>
On Thu, Nov 11, 2010 at 06:03:35AM -0800, Lighthart, EricX wrote:
> User space cannot learn the current state of a GPIO key or switch.
> Input system reports only changes, not state.
>
> Add two sysfs attributes, one each for keys and switches, that
> report lists of keys or switches currently "on."
There's EVIOCG* ioctl()s for this. Something sysfs (or a widely
distributed utility) would be very helpful but there is actually a
facility to read the state.
> drivers/input/keyboard/gpio_keys.c | 68 ++++++++++++++++++++++++++++--------
If something is needed here it should be done as part of the input
layer, not in a driver specific fashion - there's nothing specific to
GPIO keys here.
next prev parent reply other threads:[~2010-11-11 14:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 14:03 Lighthart, EricX
2010-11-11 14:15 ` Mark Brown [this message]
2010-11-11 14:24 ` Lighthart, EricX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101111141545.GB5043@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=ericx.lighthart@intel.com \
--cc=ext-mika.1.westerberg@nokia.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pb@handhelds.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®