From: Pete Zaitcev <zaitcev@redhat.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: "Németh Márton" <nm127@freemail.hu>,
"Greg Kroah-Hartman" <gregkh@suse.de>,
linux-usb@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
zaitcev@redhat.com
Subject: Re: [PATCH, RFC] usbmon: correct computing of the ISO packets with mmap
Date: Sun, 14 Nov 2010 20:42:37 -0700 [thread overview]
Message-ID: <20101114204237.7cd9e1de@lembas.zaitcev.lan> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1011142159090.4076-100000@netrider.rowland.org>
On Sun, 14 Nov 2010 22:01:58 -0500 (EST)
Alan Stern <stern@rowland.harvard.edu> wrote:
> > + * This is the look-ahead pass in case of 'Ci', when actual_length cannot
> > + * be used to determine the length of the whole contiguous buffer.
>
> Shouldn't the comment say "Cz" instead of "Ci"?
Turned out it's actually "C Zi".
> > + while (ndesc-- != 0) {
> > + if (fp->status == 0 && fp->actual_length != 0) {
>
> I'd leave out the fp->status == 0 test. It's not relevant; a buffer
> can contain valid data even if the final status isn't 0.
That's a good point, however is actual_length filled in such case?
I thought it was either one or the other.
-- Pete
next prev parent reply other threads:[~2010-11-15 3:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 6:40 usbmon: size of different fields? Németh Márton
2010-11-09 14:50 ` Pete Zaitcev
2010-11-09 20:05 ` Németh Márton
2010-11-09 21:23 ` [Wireshark-dev] " Guy Harris
2010-11-10 15:21 ` Pete Zaitcev
2010-11-10 17:36 ` Guy Harris
2010-11-13 22:15 ` [PATCH, RFC] usbmon: correct computing of the ISO packets with mmap Németh Márton
2010-11-14 19:40 ` Pete Zaitcev
2010-11-14 20:24 ` Németh Márton
2010-11-14 21:08 ` Pete Zaitcev
2010-11-14 23:25 ` Pete Zaitcev
2010-11-15 3:01 ` Alan Stern
2010-11-15 3:42 ` Pete Zaitcev [this message]
2010-11-15 15:01 ` Alan Stern
2010-11-15 5:48 ` Németh Márton
2010-11-15 6:12 ` Pete Zaitcev
2010-11-15 15:06 ` Alan Stern
2010-11-16 6:00 ` Németh Márton
2010-11-09 15:05 ` usbmon: size of different fields? Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101114204237.7cd9e1de@lembas.zaitcev.lan \
--to=zaitcev@redhat.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nm127@freemail.hu \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome