From: Pavel Machek <pma@sysgo.com>
To: eric.y.miao@gmail.com, kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: suspicious code in linux/arch/arm/common/sa1111.c
Date: Tue, 16 Nov 2010 10:07:05 +0100 [thread overview]
Message-ID: <20101116090705.GA29337@pma.sysgo.com> (raw)
Hi!
Is this good idea?
Signed-off-by: Pavel Machek <pma@sysgo.com>
diff -ur linux.ofic//arch/arm/common/sa1111.c linux/arch/arm/common/sa1111.c
--- linux.ofic//arch/arm/common/sa1111.c 2010-10-17 20:31:13.000000000 +0200
+++ linux/arch/arm/common/sa1111.c 2010-11-05 10:44:17.000000000 +0100
@@ -282,7 +312,7 @@
for (i = 0; i < 8; i++) {
sa1111_writel(ip0 ^ mask, mapbase + SA1111_INTPOL0);
sa1111_writel(ip0, mapbase + SA1111_INTPOL0);
- if (sa1111_readl(mapbase + SA1111_INTSTATCLR1) & mask)
+ if (sa1111_readl(mapbase + SA1111_INTSTATCLR0) & mask)
break;
}
next reply other threads:[~2010-11-16 9:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 9:07 Pavel Machek [this message]
2010-11-16 9:09 ` Eric Miao
2011-01-09 7:14 ` Pavel Machek
2011-01-10 22:38 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101116090705.GA29337@pma.sysgo.com \
--to=pma@sysgo.com \
--cc=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®