mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Michal Marek <mmarek@suse.cz>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
	torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
	stefani@seibold.net
Subject: Re: [RESEND PATCH] tags: put function prototypes back!
Date: Wed, 17 Nov 2010 10:06:54 +0100	[thread overview]
Message-ID: <20101117090654.GZ8942@pengutronix.de> (raw)
In-Reply-To: <1288862656-26707-1-git-send-email-u.kleine-koenig@pengutronix.de>

Hello Marek,

On Thu, Nov 04, 2010 at 10:24:16AM +0100, Uwe Kleine-König wrote:
> Commit 7db86dc (ctags: usability fix) removed function prototypes from
> tags file claiming "It makes no real sense to include function
> prototypes".
> But it is useful for quickly determining which header file developer
> needs to include to fix compilation.
> 
> Now if someone wants to remove forward declatations (which I agree are
> baggage), write a postprocessing script.
While sorting my pending patches I noticed that there's a typo, can you
please do s/declatations/declarations/ when taking the patch.
(Or tell me to resend an updated patch.)  (I'd say the sentence before
needs an "a" before developer, I'm not a native speaker though, so I
kept Alexey's wording.)

Best regards and thanks
Uwe 

> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  scripts/tags.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/tags.sh b/scripts/tags.sh
> index 8509bb5..e091db3 100755
> --- a/scripts/tags.sh
> +++ b/scripts/tags.sh
> @@ -123,7 +123,7 @@ exuberant()
>  	-I ____cacheline_internodealigned_in_smp                \
>  	-I EXPORT_SYMBOL,EXPORT_SYMBOL_GPL                      \
>  	-I DEFINE_TRACE,EXPORT_TRACEPOINT_SYMBOL,EXPORT_TRACEPOINT_SYMBOL_GPL \
> -	--extra=+f --c-kinds=-px                                \
> +	--extra=+f --c-kinds=+px                                \
>  	--regex-asm='/^ENTRY\(([^)]*)\).*/\1/'                  \
>  	--regex-c='/^SYSCALL_DEFINE[[:digit:]]?\(([^,)]*).*/sys_\1/'
>  
> -- 
> 1.7.2.3
> 
> 

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  reply	other threads:[~2010-11-17  9:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-03 20:18 [PATCH] " Alexey Dobriyan
2010-06-15  9:22 ` Uwe Kleine-König
2010-06-15  9:54   ` Michal Marek
2010-06-15 11:41     ` Uwe Kleine-König
2010-06-15 11:52       ` Michal Marek
2010-11-04  9:24         ` [RESEND PATCH] " Uwe Kleine-König
2010-11-17  9:06           ` Uwe Kleine-König [this message]
2010-12-02 11:53             ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101117090654.GZ8942@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=adobriyan@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=stefani@seibold.net \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®