mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Josef Bacik <josef@redhat.com>
To: Josef Bacik <josef@redhat.com>
Cc: Miao Xie <miaox@cn.fujitsu.com>,
	viro@zeniv.linux.org.uk, Chris Mason <chris.mason@oracle.com>,
	Linux Fsdevel <linux-fsdevel@vger.kernel.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Linux Btrfs <linux-btrfs@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ito <t-itoh@jp.fujitsu.com>
Subject: Re: [PATCH 1/3] direct-io: add a hook for the fs to provide its own bio merging check function
Date: Wed, 17 Nov 2010 04:37:21 -0500	[thread overview]
Message-ID: <20101117093720.GG5618@dhcp231-156.rdu.redhat.com> (raw)
In-Reply-To: <20101117070658.GF5618@dhcp231-156.rdu.redhat.com>

On Wed, Nov 17, 2010 at 02:06:59AM -0500, Josef Bacik wrote:
> On Wed, Nov 17, 2010 at 12:18:35PM +0800, Miao Xie wrote:
> > BTRFS can not submit bios that span its chunks or stripes, so it needs a
> > function to check it when we want to add a page into the bios. So we add a
> > can_merge_io hook to do it.
> > 
> 
> Heh so I was going to fix this after the hole punching stuff.  The fact is btrfs
> maps everything that is ok to do in one IO via get_blocks().  So all we need to
> do is add another DIO_ flag to tell us to treat each get_blocks() call as
> discrete.  I wanted to use buffer_boundary for this, but I think it's too
> drastic of a change for people who already use buffer_boundary();
> 
> What happens today is that say we map 4k, we do submit_page_section, but if this
> is our first bit of IO we just set dio->cur_page and such and then loop again.
> Say there is 4k-hole-4k, we do the next mapping and set buffer_boundary again,
> and come into submit_page_section and because cur_page is set, we do
> dio_send_cur_page.  Because there is no dio->bio we setup a new bio, but when we
> do that we clear dio->boundary, and leave the bio all setup.  So the next time
> we loop around the tail 4k gets added to our previously setup bio and boom we
> hit this problem with btrfs.
> 
> If we can add a DIO_GET_BLOCKS_DISCRETE or some other such non-sense then we can
> easily kill all the logical offset code I had and just make some simple changes
> to make the DIO stuff work for us.  All we do is in get_more_blocks we do
> 
> if ((dio->flags & DIO_GET_BLOCKS_DISCRETE) && dio->bio)
> 	dio_submit_bio(dio);
>

Right after I went to bed I realized this should be

if (dio->flags & DIO_GET_BLOCKS_DISCRETE) {
	if (dio->cur_page) {
		dio_send_cur_page(dio);
		page_cache_release(dio->cur_page);
		dio->cur_page = NULL;
	}

	if (dio->bio)
		dio_submit_bio(dio);
 }

Thanks,

Josef

  reply	other threads:[~2010-11-17  9:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17  4:18 Miao Xie
2010-11-17  7:06 ` Josef Bacik
2010-11-17  9:37   ` Josef Bacik [this message]
2010-11-17 10:11     ` Miao Xie
2010-11-17 12:50       ` Josef Bacik
2010-11-17 16:55         ` Chris Mason
2010-11-18  1:18           ` Miao Xie
2010-11-18  1:24             ` Chris Mason
2010-11-18  1:33               ` Miao Xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101117093720.GG5618@dhcp231-156.rdu.redhat.com \
    --to=josef@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=chris.mason@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miaox@cn.fujitsu.com \
    --cc=t-itoh@jp.fujitsu.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®