mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Trippelsdorf <markus@trippelsdorf.de>
To: Borislav Petkov <bp@amd64.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Borislav Petkov <bp@alien8.de>, john stultz <johnstul@us.ibm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"hpa@linux.intel.com" <hpa@linux.intel.com>,
	Ingo Molnar <mingo@elte.hu>,
	"Herrmann3, Andreas" <Andreas.Herrmann3@amd.com>,
	"heiko.carstens@de.ibm.com" <heiko.carstens@de.ibm.com>,
	"a.p.zijlstra@chello.nl" <a.p.zijlstra@chello.nl>,
	"avi@redhat.com" <avi@redhat.com>,
	"mtosatti@redhat.com" <mtosatti@redhat.com>
Subject: Re: [bisected] Clocksource tsc unstable git
Date: Thu, 18 Nov 2010 00:21:20 +0100	[thread overview]
Message-ID: <20101117232120.GA1575@arch.trippelsdorf.de> (raw)
In-Reply-To: <20101109143941.GA31121@aftab>

On 2010.11.09 at 15:39 +0100, Borislav Petkov wrote:
> On Tue, Nov 09, 2010 at 09:02:13AM -0500, Thomas Gleixner wrote:
> > > actually your board is not what concerns me, 20 ticks is still ok, more
> > > or less, but there are other machines which contain absurd values in
> > > there like 0x37ee or 0x1000 (a Broadcom chipset). We'll need to give a
> > > change like that a good run before we can be absolutely sure it doesn't
> > > break any machines.
> > 
> > If the ACPI entry is known to be flaky, shouldn't we simply err out on
> > the safe side and use 128 ticks in any case, which is not a really big
> > deal.
> 
> Yep, this is what my proposed fix does. I set it by default to 0x80 and
> the hpet detection code in acpi_parse_hpet() overrides it if it is less
> than that (and obviously a sensible value written by the BIOS).
> 
> Otherwise it issues a warning. Come to think of it, we shouldn't be
> issuing a warning because this'll scream on a very high number of
> systems, IMHO, especially older boards. Instead, we should issue it in
> dmesg during boot just in case.
> 
> The other concern I have is whether min tick of 128 would work for _all_
> possible HPET implementations - I don't know whether there are some very
> b0rked incarnations which delay HPET accesses to more than 128 cycles.
> Kinda hard to say.
> 
> So, to be more specific, here's what I have in mind:

Any update on this issue?

Borislav's patch solves the mysterious "slowdown" problem and is running
without problems for the last two weeks here. 

(And rc2 is already out. So maybe it's time to push this to Linus so
that more people have a chance to test it?)
-- 
Markus

  reply	other threads:[~2010-11-17 23:21 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-26 11:20 Clocksource tsc unstable (delta = -8589361717 ns) in current git Markus Trippelsdorf
2010-10-26 13:18 ` Borislav Petkov
2010-10-26 13:58   ` Markus Trippelsdorf
2010-10-26 14:05     ` Markus Trippelsdorf
2010-10-26 14:38     ` Peter Zijlstra
2010-10-26 15:46       ` Thomas Gleixner
2010-10-26 16:41         ` Borislav Petkov
2010-10-26 15:48     ` Thomas Gleixner
2010-10-26 17:56       ` Markus Trippelsdorf
2010-10-26 18:19         ` Borislav Petkov
2010-10-26 19:18       ` john stultz
2010-10-27 14:26         ` Markus Trippelsdorf
2010-10-27 18:26           ` [bisected] Clocksource tsc unstable git markus
2010-10-27 19:36             ` Peter Zijlstra
2010-10-27 19:42               ` Markus Trippelsdorf
2010-10-27 19:58               ` Marcelo Tosatti
2010-11-09 12:58               ` Heiko Carstens
2010-11-09 13:07                 ` Markus Trippelsdorf
2010-11-09 13:21                 ` Markus Trippelsdorf
2010-11-09 13:28                   ` Heiko Carstens
2010-11-09 13:45                   ` Peter Zijlstra
2010-11-09 13:33                 ` Peter Zijlstra
2010-10-29  8:18             ` Borislav Petkov
2010-10-29  8:30               ` Markus Trippelsdorf
2010-10-29 10:27                 ` Borislav Petkov
2010-10-29 11:34                   ` Markus Trippelsdorf
2010-10-29 11:39                     ` Borislav Petkov
2010-10-29 11:54                       ` Markus Trippelsdorf
2010-10-29 13:13                         ` Borislav Petkov
2010-10-29 12:14                   ` Thomas Gleixner
2010-10-29 17:00                     ` Borislav Petkov
2010-10-29 17:26                       ` Markus Trippelsdorf
2010-11-01 18:05                         ` Thomas Gleixner
2010-11-01 18:45                           ` Markus Trippelsdorf
2010-11-02 15:26                             ` Thomas Gleixner
2010-11-05 16:09                               ` Borislav Petkov
2010-11-05 16:42                                 ` Markus Trippelsdorf
2010-11-05 17:45                                   ` Markus Trippelsdorf
2010-11-05 21:27                                   ` Markus Trippelsdorf
2010-11-05 21:32                                     ` Borislav Petkov
2010-11-09 14:02                                       ` Thomas Gleixner
2010-11-09 14:39                                         ` Borislav Petkov
2010-11-17 23:21                                           ` Markus Trippelsdorf [this message]
2010-11-24 11:25                                             ` Borislav Petkov
2010-10-29 17:34                       ` Thomas Gleixner
2010-10-27  3:24     ` Clocksource tsc unstable (delta = -8589361717 ns) in current git Mike Galbraith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101117232120.GA1575@arch.trippelsdorf.de \
    --to=markus@trippelsdorf.de \
    --cc=Andreas.Herrmann3@amd.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=avi@redhat.com \
    --cc=bp@alien8.de \
    --cc=bp@amd64.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hpa@linux.intel.com \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mtosatti@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®