From: David Miller <davem@davemloft.net>
To: grant.likely@secretlab.ca
Cc: ddaney@caviumnetworks.com, devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] phylib: Add support for Marvell 88E1149R devices.
Date: Thu, 18 Nov 2010 12:57:17 -0800 (PST) [thread overview]
Message-ID: <20101118.125717.52197531.davem@davemloft.net> (raw)
In-Reply-To: <20101118204410.GB16908@angua.secretlab.ca>
From: Grant Likely <grant.likely@secretlab.ca>
Date: Thu, 18 Nov 2010 13:44:10 -0700
> On Thu, Nov 18, 2010 at 11:46:16AM -0800, David Miller wrote:
>> From: David Daney <ddaney@caviumnetworks.com>
>> Date: Wed, 17 Nov 2010 15:54:31 -0800
>>
>> > The 88E1149R is 10/100/1000 quad-gigabit Ethernet PHY. The
>> > .config_aneg function can be shared with 88E1118, but it needs its own
>> > .config_init.
>> >
>> > Signed-off-by: David Daney <ddaney@caviumnetworks.com>
>>
>> Please resend this when you've respun patch #1 based upon the feedback
>> you've been given.
>
> It looks to me that this patch has no dependencies on the first patch.
> ddaney; what say you?
It absolutely does, it references a function create by patch #1
In fact it's the whole _entire_ point of patch #1, to allow
patch #2 to be possible. Did you even check?
Otherwise I would waste his time asking for a respin.
next prev parent reply other threads:[~2010-11-18 20:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 23:54 [PATCH 0/2] of/phylib: Use device tree properties for PHY configuration David Daney
2010-11-17 23:54 ` [PATCH 1/2] of/phylib: Use device tree properties to initialize Marvell PHYs David Daney
2010-11-18 0:01 ` David Daney
[not found] ` <marvell-phy@mdm.bga.com>
2010-11-18 17:40 ` [1/2] " David Daney
2010-11-18 19:32 ` [PATCH 1/2] " Cyril Chemparathy
2010-11-18 20:40 ` Grant Likely
2010-11-18 23:48 ` David Daney
2010-11-19 0:39 ` Grant Likely
2010-11-17 23:54 ` [PATCH 2/2] phylib: Add support for Marvell 88E1149R devices David Daney
2010-11-18 19:46 ` David Miller
2010-11-18 20:44 ` Grant Likely
2010-11-18 20:57 ` David Miller [this message]
2010-11-18 21:06 ` David Daney
2010-11-19 21:58 [PATCH 0/2] phylib: Cleanup marvell.c and add 88E1149R support David Daney
2010-11-19 21:58 ` [PATCH 2/2] phylib: Add support for Marvell 88E1149R devices David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118.125717.52197531.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ddaney@caviumnetworks.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome