From: Herbert Xu <herbert@gondor.hengli.com.au>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: tadeusz.struk@intel.com, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org, aidan.o.mahony@intel.com,
gabriele.paoloni@intel.com, adrian.hoban@intel.com
Subject: Re: [PATCH 2/3] RFC4106 AES-GCM Driver Using Intel New Instructions
Date: Thu, 18 Nov 2010 17:26:40 +0800 [thread overview]
Message-ID: <20101118092640.GA9486@gondor.apana.org.au> (raw)
In-Reply-To: <20101117172331.3bbec734.akpm@linux-foundation.org>
On Wed, Nov 17, 2010 at 05:23:31PM -0800, Andrew Morton wrote:
> On Thu, 4 Nov 2010 14:04:05 -0500
> Herbert Xu <herbert@gondor.hengli.com.au> wrote:
>
> > On Thu, Oct 28, 2010 at 04:19:09PM +0100, tadeusz.struk@intel.com wrote:
> > > Hi Herbert,
> > > We have reworked the assembly to use macros instead of the new aesni instructions.
> >
> > Both applied. Thanks for your efforts!
>
> Whatever's in today's linux-next is a big fail with gas-2.16.1.
>
> Which was entirely predictable! How often has this happened recently??
>
>
> arch/x86/crypto/aesni-intel_asm.S: Assembler messages:
> arch/x86/crypto/aesni-intel_asm.S:834: Error: no such instruction: `pshufb SHUF_MASK(%rip),%xmm13'
> arch/x86/crypto/aesni-intel_asm.S:866: Error: no such instruction: `pshufb SHUF_MASK(%rip),%xmm5'
> arch/x86/crypto/aesni-intel_asm.S:866: Error: no such instruction: `pshufb SHUF_MASK(%rip),%xmm0'
> arch/x86/crypto/aesni-intel_asm.S:866: Error: bad expression
Sorry, but I no longer have access to a binutils that is older
than 2.18 so I never saw this failure.
Tadeusz, could you please make an incremental patch that converts
all the pshufb instructions to macros?
Thanks!
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2010-11-18 9:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 15:19 tadeusz.struk
2010-11-04 19:04 ` Herbert Xu
2010-11-18 1:23 ` Andrew Morton
2010-11-18 9:26 ` Herbert Xu [this message]
2010-11-18 9:38 ` Struk, Tadeusz
2010-12-03 0:14 ` Andrew Morton
2010-12-03 1:30 ` Herbert Xu
2010-12-03 11:05 ` Struk, Tadeusz
2010-12-14 2:21 ` Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2010-10-12 8:31 tadeusz.struk
2010-10-19 12:49 ` Herbert Xu
[not found] ` <44813D8942D35947805CBEEA94195BB001B135B69E@irsmsx505.ger.corp.intel.com>
[not found] ` <24483BA4C9F69C43A7379639D35543D7C2F99F27@irsmsx502.ger.corp.intel.com>
2010-10-20 10:49 ` Hoban, Adrian
2010-10-20 13:02 ` Herbert Xu
2010-10-11 15:48 tadeusz.struk
2010-09-10 17:36 Hoban, Adrian
2010-09-20 8:07 ` Herbert Xu
[not found] ` <AANLkTim_gVO2tHUw+vFC9vXRh8Dtv7N38HTCMUZ7LmNg@mail.gmail.com>
2010-09-20 11:21 ` Struk, Tadeusz
2010-09-23 7:58 ` Herbert Xu
2010-09-24 10:07 ` Paoloni, Gabriele
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118092640.GA9486@gondor.apana.org.au \
--to=herbert@gondor.hengli.com.au \
--cc=adrian.hoban@intel.com \
--cc=aidan.o.mahony@intel.com \
--cc=akpm@linux-foundation.org \
--cc=gabriele.paoloni@intel.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®