mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [build failure] Re: BKL: remove extraneous #include <smp_lock.h>
Date: Thu, 18 Nov 2010 20:02:05 +0100	[thread overview]
Message-ID: <20101118190205.GB10827@elte.hu> (raw)
In-Reply-To: <AANLkTikV+KVmwKg4jS2KPG+9EFdd9qD-VUak4qOgFgr4@mail.gmail.com>


* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Thu, Nov 18, 2010 at 7:57 AM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > How painful would it be to move lock_depth into thread_struct? I guess
> > we don't have anything that cares about structure offsets in assembly
> > for that thing.  I should just try.
> 
> Gaah, the only generic field there is the restart_block, so we'd have
> to hide it there, or then add it to each architecture. So scratch
> that.
> 
> I guess this is the simplest approach.
> 
>                          Linus

>  include/linux/hardirq.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/hardirq.h b/include/linux/hardirq.h
> index 714da7e..32f9fd6 100644
> --- a/include/linux/hardirq.h
> +++ b/include/linux/hardirq.h
> @@ -94,6 +94,7 @@
>  #define in_nmi()	(preempt_count() & NMI_MASK)
>  
>  #if defined(CONFIG_PREEMPT) && defined(CONFIG_BKL)
> +# include <linux/sched.h>
>  # define PREEMPT_INATOMIC_BASE (current->lock_depth >= 0)
>  #else
>  # define PREEMPT_INATOMIC_BASE 0

Hey, i will quote this patch in the future, when you flame me about some ugly 
compatibility hack ;-)

I guess it will all go away with CONFIG_BKL so we dont really care so deeply. I'll 
test it.

Thanks,

	Ingo

  parent reply	other threads:[~2010-11-18 19:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201011172159.oAHLx1tu001236@hera.kernel.org>
2010-11-17 22:05 ` Randy Dunlap
2010-11-17 22:23   ` Linus Torvalds
2010-11-17 22:37     ` Randy Dunlap
2010-11-17 22:43     ` Arnd Bergmann
2010-11-18  9:43     ` [build failure] " Ingo Molnar
2010-11-18 15:57       ` Linus Torvalds
2010-11-18 16:02         ` Linus Torvalds
2010-11-18 16:28           ` Randy Dunlap
2010-11-18 19:02           ` Ingo Molnar [this message]
2010-11-18 19:04             ` Randy Dunlap
2010-11-18 19:44             ` Linus Torvalds
2010-11-18 19:51             ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101118190205.GB10827@elte.hu \
    --to=mingo@elte.hu \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®