From: Joel Becker <Joel.Becker@oracle.com>
To: dann frazier <dann.frazier@canonical.com>
Cc: ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [Ocfs2-devel] [PATCH] [OCFS2] ocfs2_connection_find() returns pointer to bad structure
Date: Thu, 18 Nov 2010 15:45:27 -0800 [thread overview]
Message-ID: <20101118234527.GL19821@mail.oracle.com> (raw)
In-Reply-To: <1290117789-3915-1-git-send-email-dann.frazier@canonical.com>
On Thu, Nov 18, 2010 at 03:03:09PM -0700, dann frazier wrote:
> If ocfs2_live_connection_list is empty, ocfs2_connection_find() will return
> a pointer to the LIST_HEAD, cast as a ocfs2_live_connection. This can cause
> an oops when ocfs2_control_send_down() dereferences c->oc_conn:
>
> Call Trace:
> [<ffffffffa00c2a3c>] ocfs2_control_message+0x28c/0x2b0 [ocfs2_stack_user]
> [<ffffffffa00c2a95>] ocfs2_control_write+0x35/0xb0 [ocfs2_stack_user]
> [<ffffffff81143a88>] vfs_write+0xb8/0x1a0
> [<ffffffff8155cc13>] ? do_page_fault+0x153/0x3b0
> [<ffffffff811442f1>] sys_write+0x51/0x80
> [<ffffffff810121b2>] system_call_fastpath+0x16/0x1b
>
> Fix by explicitly returning NULL if no match is found.
>
> Signed-off-by: dann frazier <dann.frazier@canonical.com>
This patch is now in the fixes branch of ocfs2.git.
Joel
--
"I don't even butter my bread; I consider that cooking."
- Katherine Cebrian
Joel Becker
Senior Development Manager
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
prev parent reply other threads:[~2010-11-18 23:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 22:03 dann frazier
2010-11-18 23:45 ` Joel Becker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118234527.GL19821@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=dann.frazier@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome