From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757010Ab0KSVe2 (ORCPT ); Fri, 19 Nov 2010 16:34:28 -0500 Received: from kroah.org ([198.145.64.141]:44421 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756872Ab0KSVd4 (ORCPT ); Fri, 19 Nov 2010 16:33:56 -0500 X-Mailbox-Line: From gregkh@clark.site Fri Nov 19 13:32:32 2010 Message-Id: <20101119213231.949256463@clark.site> User-Agent: quilt/0.48-11.2 Date: Fri, 19 Nov 2010 13:30:49 -0800 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: stable-review@kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Dan Carpenter , James Bottomley Subject: [4/5] [SCSI] gdth: integer overflow in ioctl In-Reply-To: <20101119213300.GA4637@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2.6.27-stable review patch. If anyone has any objections, please let us know. ------------------ From: Dan Carpenter commit f63ae56e4e97fb12053590e41a4fa59e7daa74a4 upstream. gdth_ioctl_alloc() takes the size variable as an int. copy_from_user() takes the size variable as an unsigned long. gen.data_len and gen.sense_len are unsigned longs. On x86_64 longs are 64 bit and ints are 32 bit. We could pass in a very large number and the allocation would truncate the size to 32 bits and allocate a small buffer. Then when we do the copy_from_user(), it would result in a memory corruption. Signed-off-by: Dan Carpenter Signed-off-by: James Bottomley Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/gdth.c | 8 ++++++++ 1 file changed, 8 insertions(+) --- a/drivers/scsi/gdth.c +++ b/drivers/scsi/gdth.c @@ -4155,6 +4155,14 @@ static int ioc_general(void __user *arg, ha = gdth_find_ha(gen.ionode); if (!ha) return -EFAULT; + + if (gen.data_len > INT_MAX) + return -EINVAL; + if (gen.sense_len > INT_MAX) + return -EINVAL; + if (gen.data_len + gen.sense_len > INT_MAX) + return -EINVAL; + if (gen.data_len + gen.sense_len != 0) { if (!(buf = gdth_ioctl_alloc(ha, gen.data_len + gen.sense_len, FALSE, &paddr)))