From: Alexey Zaytsev <alexey.zaytsev@gmail.com>
To: Eric Paris <eparis@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] Shrink fanotify_event_metadata by 32 bits
Date: Sat, 20 Nov 2010 05:08:22 +0000 [thread overview]
Message-ID: <20101120050353.32269.90666.stgit@zaytsev.su> (raw)
There seems to be no point wasting 32 bits for either the event version or length
Signed-off-by: Alexey Zaytsev <alexey.zaytsev@gmail.com>
---
Hi.
While I'm working on the file modification events,
please consider this patch. It obviously breaks
the userspace ABI. But maybe that's acceptable, given
that no kernel has ever been released with the old ABI.
And the users only need to recompile their code, without
changing anything.
If we agree that this change is desirable, please make sure
it makes it to Linus before the release. ;)
include/linux/fanotify.h | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/include/linux/fanotify.h b/include/linux/fanotify.h
index 0f01214..9a7986f 100644
--- a/include/linux/fanotify.h
+++ b/include/linux/fanotify.h
@@ -86,10 +86,11 @@
#define FANOTIFY_METADATA_VERSION 2
struct fanotify_event_metadata {
- __u32 event_len;
- __u32 vers;
- __aligned_u64 mask;
+ __u16 event_len;
+ __u8 vers;
+ __u8 reserved;
__s32 fd;
+ __aligned_u64 mask;
__s32 pid;
};
next reply other threads:[~2010-11-20 5:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-20 5:08 Alexey Zaytsev [this message]
2010-11-20 21:03 ` Alexey Zaytsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101120050353.32269.90666.stgit@zaytsev.su \
--to=alexey.zaytsev@gmail.com \
--cc=eparis@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®